Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ownCloud: Update to v10.14.0 #6132

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Conversation

mreid-tt
Copy link
Contributor

@mreid-tt mreid-tt commented Jun 9, 2024

Description

This PR contains the following:

  1. Update ownCloud to version 10.14.0
  2. Enable iconv php module

Fixes #

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Package update

@mreid-tt mreid-tt merged commit c1a463a into SynoCommunity:master Jun 9, 2024
17 checks passed
@mreid-tt mreid-tt deleted the owncloud-update branch June 9, 2024 23:42
@mreid-tt
Copy link
Contributor Author

@hgy59 @th0ma7, I'm not sure what's going on here. I've built a new version of a very basic package (ownCloud) and then tried to publish it without success: https://github.com/mreid-tt/spksrc/actions/runs/9440376248. Any thoughts?

@hgy59
Copy link
Contributor

hgy59 commented Jun 10, 2024

Regarding the build log, the package is not even built, it is only supposed to be uploaded.

Probably related to #6002
There already have been attemps to fix publishing in #6038, #6064, #6066. #6067, ...

#6002 was merged on April 1st, 2024. Has no one published "noarch" packages recently.

@mreid-tt
Copy link
Contributor Author

mreid-tt commented Jun 10, 2024

#6002 was merged on April 1st, 2024. Has no one published "noarch" packages recently.

Hmm, I wouldn't say that is true since AriaNg was published on 2024-04-07. However it may have been published from a local build rather than with GitHub?

@th0ma7
Copy link
Contributor

th0ma7 commented Jun 10, 2024

I think you're right @hgy59. Looking at the code the publish standalone call does not preclude calling building.

This either requires changes in mk or in build.sh we do first a build then publish:

make TCVERSION=${TCVERSION} ARCH= -C ./spk/${package}
make TCVERSION=${TCVERSION} ARCH= -C ./spk/${package} ${MAKE_ARGS%%-}

@th0ma7 th0ma7 mentioned this pull request Jun 11, 2024
10 tasks
@th0ma7
Copy link
Contributor

th0ma7 commented Jun 11, 2024

@mreid-tt can you rebase against master and confirm if this is working out as expected #6134 ?

@mreid-tt mreid-tt added status/published Published and activated (may take up to 48h until visible in DSM package manager) and removed status/to-publish labels Jun 11, 2024
@mreid-tt
Copy link
Contributor Author

@mreid-tt can you rebase against master and confirm if this is working out as expected #6134 ?

Yes it did. Thanks @th0ma7

@th0ma7
Copy link
Contributor

th0ma7 commented Jun 11, 2024

Great! Thnx for confirming, cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/published Published and activated (may take up to 48h until visible in DSM package manager)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants