synocli-file: add pixz #6149
Open
synocli-file: add pixz #6149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also fix license
- build from pre-configured tarball instead of raw source - which seems to support GNU configure - libcrytpo is runtime dependency - don't include bsd* cli; just shared object only
- patched to allow cross-compile
I have no idea why. But spk/synocli-file would not build pixz. However, cross/libarchive and diyspk/pigz both built standalone just fine. Also documenting some other strange and no-determininistic artifacts linked to build enviornment.
Link shared object aliases instead of copy. Co-authored-by: hgy59 <[email protected]>
|
Not sure what I'm doing wrong here. Tried disabling hi3535-6.2.4 with: to no avail. |
don't worry about ARMv7L_ARCHS. |
- disable to build tools (we want the library only) - document the need to build without libiconv - disable static build and add code optimization to minimize library size - libarchive builds without native/autoconf
- use configure parameter to avoid the AC_CHECK_FILE patch - do not disable build for ARMv7L_ARCHS - update changelog for synocli-file package
|
@dotysan my review is embedded in the two commits... Still pending is the question whether we should use a newer code base for pixz, referenced by git commit hash. (or we can wait for an answer to your question in vasi/pixz#116) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting over from scratch after I completely bungled #6075.