Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet: add dotnet 9.0 runtime #6335

Closed
wants to merge 6 commits into from

Conversation

brice-fromentin
Copy link
Contributor

@brice-fromentin brice-fromentin commented Nov 28, 2024

Description

Package with dotnet 9 release.

Fixes #6343

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@brice-fromentin brice-fromentin changed the title First dotnet 9 release. .NET 9 package. [new] Dec 4, 2024
@mreid-tt mreid-tt changed the title .NET 9 package. [new] dotnet: add dotnet 9.0 runtime Dec 4, 2024
@hgy59
Copy link
Contributor

hgy59 commented Dec 4, 2024

@brice-fromentin do you really need .net 9?
my intention was to create packages for LTS versions only (i.e. version 8, 10, 12, ...)

@mreid-tt
Copy link
Contributor

mreid-tt commented Dec 4, 2024

@brice-fromentin, thanks for your contribution. Looking at #5972, I believe that @hgy59 may prefer a consistent folder naming structure. So rather than having your package folder in spk/ and cross/ called dotnet-9-runtime, perhaps you can use dotnet9-runtime for consistency.

Other than that the notes I left in the Makefile are the only things I picked up that may need addressing.

@brice-fromentin
Copy link
Contributor Author

@brice-fromentin do you really need .net 9? my intention was to create packages for LTS versions only (i.e. version 8, 10, 12, ...)

Yes there is a lot of benefits on it.

@brice-fromentin
Copy link
Contributor Author

@brice-fromentin, thanks for your contribution. Looking at #5972, I believe that @hgy59 may prefer a consistent folder naming structure. So rather than having your package folder in spk/ and cross/ called dotnet-9-runtime, perhaps you can use dotnet9-runtime for consistency.

Other than that the notes I left in the Makefile are the only things I picked up that may need addressing.

Thanks for your feedbacks, I update with those.

Apply recommandations from previous pull request.
@mreid-tt
Copy link
Contributor

mreid-tt commented Dec 5, 2024

I notice that you moved the DSM minimum from 7.0 to 7.1. Was there any particular reason for this? What is the primary logic you are using to determine minimum DSM version?

Also, until the package is published there is no need to change the SPK_REV. It should stay as 1 for now.

@brice-fromentin
Copy link
Contributor Author

I notice that you moved the DSM minimum from 7.0 to 7.1. Was there any particular reason for this? What is the primary logic you are using to determine minimum DSM version?

Also, until the package is published there is no need to change the SPK_REV. It should stay as 1 for now.

Thx for your help, I switched back to 7.0 because there is no real requirements.

spk/dotnet9-runtime/Makefile Outdated Show resolved Hide resolved
spk/dotnet9-runtime/Makefile Outdated Show resolved Hide resolved
@mreid-tt
Copy link
Contributor

mreid-tt commented Dec 5, 2024

@brice-fromentin, my apologies for not catching this earlier. It seems you're making edits directly on the master branch rather than using a dedicated branch. This approach deviates from our standard practice, as it can complicate maintenance, as previously pointed out by @hgy59. You might need to create a new PR following the correct workflow.

EDIT: I recommend saving your modified files, creating a new branch, and moving the modified files into it. Everything else can be copied from this PR.

@brice-fromentin
Copy link
Contributor Author

@brice-fromentin, my apologies for not catching this earlier. It seems you're making edits directly on the master branch rather than using a dedicated branch. This approach deviates from our standard practice, as it can complicate maintenance, as previously pointed out by @hgy59. You might need to create a new PR following the correct workflow.

EDIT: I recommend saving your modified files, creating a new branch, and moving the modified files into it. Everything else can be copied from this PR.

@mreid-tt , sorry, I do it like that.

@brice-fromentin brice-fromentin closed this by deleting the head repository Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request] .NET 9
3 participants