-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet: add dotnet 9.0 runtime #6335
Conversation
@brice-fromentin do you really need .net 9? |
@brice-fromentin, thanks for your contribution. Looking at #5972, I believe that @hgy59 may prefer a consistent folder naming structure. So rather than having your package folder in Other than that the notes I left in the Makefile are the only things I picked up that may need addressing. |
Yes there is a lot of benefits on it. |
Thanks for your feedbacks, I update with those. |
Apply recommandations from previous pull request.
I notice that you moved the DSM minimum from 7.0 to 7.1. Was there any particular reason for this? What is the primary logic you are using to determine minimum DSM version? Also, until the package is published there is no need to change the |
Thx for your help, I switched back to 7.0 because there is no real requirements. |
Co-authored-by: hgy59 <[email protected]>
Co-authored-by: hgy59 <[email protected]>
@brice-fromentin, my apologies for not catching this earlier. It seems you're making edits directly on the master branch rather than using a dedicated branch. This approach deviates from our standard practice, as it can complicate maintenance, as previously pointed out by @hgy59. You might need to create a new PR following the correct workflow. EDIT: I recommend saving your modified files, creating a new branch, and moving the modified files into it. Everything else can be copied from this PR. |
@mreid-tt , sorry, I do it like that. |
Description
Package with dotnet 9 release.
Fixes #6343
Checklist
all-supported
completed successfullyType of change