Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ombi: Patch for v4.44.1 (Min DSM 7.2) #6347

Closed
wants to merge 1 commit into from

Conversation

mreid-tt
Copy link
Contributor

@mreid-tt mreid-tt commented Dec 8, 2024

Description

This is a follow-on from #6323 to set the minimum DSM version to 7.2 for compatibility with Sqlite 8.0.5.

Fixes #6346

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix

@mreid-tt mreid-tt self-assigned this Dec 8, 2024
@mreid-tt mreid-tt requested a review from hgy59 December 8, 2024 03:03
@hgy59
Copy link
Contributor

hgy59 commented Dec 8, 2024

@mreid-tt did you ever try to configure ombi to use MySQL/MaridaDB ?
There are 3 databases in omby that can use different db servers (default is MySQL/SQLite/SQLite) but you can configure all tree without SQLite)
https://docs.ombi.app/info/alternate-databases/

@mreid-tt
Copy link
Contributor Author

mreid-tt commented Dec 8, 2024

@hgy59, no, I haven’t explored this yet. Moving in this direction would require significant effort, including creating install wizards, service setup scripts, and related changes. Moreover, it would likely represent a permanent shift since, as far as I know, there’s no way to dynamically adjust package dependencies at install time (e.g., letting the user choose between SQLite and MariaDB and having the dependencies update accordingly).

Additionally, database migration between the two options would likely involve considerable work for existing installations. Scripting such migrations reliably has historically been challenging (e.g., with ownCloud). Do you think this direction is worth pursuing, given the potential complexity and effort involved?

@mreid-tt mreid-tt closed this Dec 8, 2024
@mreid-tt mreid-tt deleted the ombi-patch branch December 8, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ombi v4.44.1 crash on DSM 7.1.1
2 participants