Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(networks): define a stander way of adding/switching networks #770

Closed
wants to merge 7 commits into from

Conversation

neuodev
Copy link
Contributor

@neuodev neuodev commented May 31, 2023

Motivation and context

TODO

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

@cypress
Copy link

cypress bot commented May 31, 2023

Passing run #328 ↗︎

0 159 12 0 Flakiness 0

Details:

fix(networks): define a stander way of adding/switching networks
Project: synpress Commit: 823f15f412
Status: Passed Duration: 19:10 💡
Started: Jul 25, 2023 1:23 PM Ended: Jul 25, 2023 1:43 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@neuodev neuodev changed the title fix: define a stander way of adding/switching networks fix(networks): define a stander way of adding/switching networks Jun 1, 2023
@neuodev neuodev marked this pull request as ready for review June 2, 2023 14:20
@neuodev neuodev requested review from drptbl and r3kt-eth June 2, 2023 14:20
@neuodev neuodev self-assigned this Jun 2, 2023
@neuodev
Copy link
Contributor Author

neuodev commented Jun 5, 2023

Fix: adding custom wallets should not be restricted to networks defined in wagmi

@neuodev neuodev marked this pull request as draft June 5, 2023 18:28
@neuodev neuodev marked this pull request as ready for review June 7, 2023 14:25
@drptbl
Copy link
Collaborator

drptbl commented Aug 18, 2023

We're planning to come back to this in future after we're done with TS migration. There will be much breaking changes on the way, thus I'm closing this PR.

@drptbl drptbl closed this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants