Skip to content
This repository has been archived by the owner on Dec 17, 2019. It is now read-only.

[IMP] Multiple improvements #24

Merged
merged 7 commits into from
Jul 31, 2018
Merged

[IMP] Multiple improvements #24

merged 7 commits into from
Jul 31, 2018

Conversation

aitorbouzas
Copy link

I will be improving step by step some things I consider are not well designed.
Have you considered adding this vertical into OCA?

@aitorbouzas aitorbouzas changed the title [IMP] Adding sequence for ticket number, deleting ticket number display [IMP] Multiple improvements Jul 20, 2018
@SythilTech
Copy link
Owner

While I agree the fake ticket number could use a revamp and sequences provide new functionality (number padding, etc) I might slate that change for the version 12 port as anyone that updates the module would unexpectedly have there number reset.

I like the timezone translation on the website as that will help to reduce confusion for companies that operate across time zones.

Also could you elaborate what you mean by "Have you considered adding this vertical into OCA?"

@aitorbouzas
Copy link
Author

aitorbouzas commented Jul 23, 2018

Maybe we could make a migration script for the ticket number column. Want me to create one?
With adding this vertical into OCA I mean to add the helpdesk addons into OCA repositories (Odoo Community Association) so the community can upgrade it and maintain it. This is a very nice module (and I thank you very much for your effort, indeed) that is missing in Odoo 11 CE.

@SythilTech
Copy link
Owner

Sure a migration script is fine as long as it can automatically be run when someone upgrades to 1.2.14

If the OCA want to maintain it, I'll happily transfer it to them, I could always use a lighter plate.

@aitorbouzas
Copy link
Author

@SythilTech fine, the migration script is done, it takes into account the already taken numbers for tickets and updates the sequence to the higher number plus one.
Check also views improvements.

CC @pedrobaeza

@SythilTech
Copy link
Owner

The condensed ticket view is nice, I'll do one last check next time I'm doing some Odoo dev work then give more feedback or otherwise just accept the pull.

I'll also check with OCA if they want to take over the module as it could use a good home now that mostly doing non Odoo stuff nowadays.

@pedrobaeza
Copy link

@aitorbouzas you pinged me for any special reason?

@aitorbouzas
Copy link
Author

Yes @pedrobaeza
I was asking @SythilTech if he's interested in merging this module into OCA. I was just wondering how should we proceed, just making a new PR?

@pedrobaeza
Copy link

Thanks for clarifying. Well, first of all, this maybe overlaps some things with existing modules (or maybe the core, as there's support now for showing tasks in website portal directly on core module). There's also a proposal for a helpdesk module (on backend). I don't know this one, but a good start can be to put an issue on OCA for explaining the approach and coverage of this module to see what people thinks, and then a PR over OCA signing the CLA.

@SythilTech SythilTech merged commit d5ec3d4 into SythilTech:11.0 Jul 31, 2018
@SythilTech SythilTech mentioned this pull request Oct 29, 2018
@nacho-domatix
Copy link

nacho-domatix commented Oct 29, 2018

We could help with the migration to OCA as we are currently working on this module, we already made some improvements for v11 version. Soon a PR will be ready with everything. cc @carlosDomatix
bitmap
(sorry for the spanish language in the screenshots, but the changes can be seen anyway :P)

@aitorbouzas
Copy link
Author

@dxnacho count on me for reviewing and helping. I've been working with this module with some customers for some time now.

@nacho-domatix
Copy link

We're working just on v11, but as I said, a PR will be available soon with all the changes so you'll be able to test them (and improve it!). Thank you :)

@nacho-domatix
Copy link

@aitorbouzas take a look at this: #50

@nacho-domatix
Copy link

Hi,
There's gonna be an OCA code sprint next week and we're going to arrange a table with 4-5 developers full time during the whole code sprint just to move this code to OCA repos.

Is there any chance some people of @SythilTech team can have some time to guide us and supervise all the work? Would be awesome to have a great community contributing to make this "Helpdesk" the community one.

cc @DarioLodeiros

@DarioLodeiros
Copy link

Hi!
@SythilTech , as nacho says, we want to raise a work table to incorporate helpdesk to oca on Sada CodeSprint.
To be able to base the repository on this module and not lose the authorship of the commits,, we need that all contributors are in agreement with this decision and sign the CLA of the OCA.
Since we will be working on this from Monday 27, We need to have your confirmation this week, so we can work on adapting this module to OCA during the codesprint.
Thanks!

@SythilTech
Copy link
Owner

Hi sorry for the late delay seems I missed the 27th, was busy that day anyway as I have a lot of part-time / casual jobs outside of Sythil Tech that keep me busy.

OK, I'm fine with signing the CLA, I'll have to compile a full list of contributors as many people have contributed ideas, bug report and even code via email instead of GitHub and it looks like OCA wants a signature from everyone.

@aitorbouzas
Copy link
Author

Sorry @SythilTech but we just remade the entire module. We did not take any of your code, we just simply made a simple base module helpdesk which will set a foundation over which other contributors can add their own functionalities.
The OCA repository is in https://github.com/OCA/helpdesk and as you will see there's a first PR with the base module.

@nacho-domatix
Copy link

Hi @SythilTech

As @aitorbouzas said, developers took already the decision to start it from scratch. It wil be available only from v11 so please consider to contribute to this module in the future instead of continuing your own. There are some advantages in refactoring, and all the features of your module will be developed too.

We'll be stronger if we unify forces ;) .. and OCA is the best place to be for Odoo code.

@SythilTech
Copy link
Owner

OK, that's cool it does seem like a good idea to start from scratch that way it can be built more modular so it doesn't depend on the website module, there is also a lot of features I've considered redesigning now that the module had grown so much from it's initial concept of a website form to generate support tickets.

I'll see if I can contribute the next time I have a free day or two.

@aitorbouzas
Copy link
Author

@SythilTech that would be awesome!

As you say, the base module doesn't depend on website and it already has a nice portal view for portal users nicely integrated with Odoo. I hope you can unite your forces with us.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants