Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zh-hk.yml): Added Traditional Chinese language #110

Merged
merged 9 commits into from
Jun 4, 2024

Conversation

chunkiuu
Copy link
Contributor

@chunkiuu chunkiuu commented Jun 3, 2024

Changes:
Added Traditional Chinese language zh-hk.yml

I have ensured all translations are correct, as I am a native speaker of the Traditional Chinese language. :D

@chunkiuu chunkiuu marked this pull request as draft June 3, 2024 10:43
@chunkiuu chunkiuu marked this pull request as ready for review June 3, 2024 12:23
Copy link
Owner

@Sytm Sytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your very much for this contribution!

Although there are some tiny issues that should be resolved quickly

waypoints/src/main/resources/lang/zh-hk.yml Outdated Show resolved Hide resolved
waypoints/src/main/resources/lang/zh-hk.yml Outdated Show resolved Hide resolved
sharedWaypoints: "<dark_gray>與你共享的座標"
# waypoint: Name of the waypoint
sharedWith: "<dark_gray>你與以下玩家共享的 <gold><waypoint></gold>"
confirm: "<dark_gray>你確定嗎?"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing space

waypoints/src/main/resources/lang/zh-hk.yml Outdated Show resolved Hide resolved
waypoints/src/main/resources/lang/zh-hk.yml Show resolved Hide resolved
@chunkiuu
Copy link
Contributor Author

chunkiuu commented Jun 3, 2024

I have made a corrected version zh-hk.yml
Sorry for having too many errors. The indentation problems should be fixed. Now it should be exactly the same as the en.yml.
Let me know if there are more mistakes that need to be fixed :D

@chunkiuu chunkiuu requested a review from Sytm June 3, 2024 18:46
@Sytm Sytm merged commit 5a5ef21 into Sytm:v4/master Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants