Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22 - Reenable support for Flat XML OpenDocumentFormat files #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonadem
Copy link

@jonadem jonadem commented Jul 26, 2017

A ".fodt" document is already in the repository.
I could test my commit with this small modification :

diff --git a/tests/test_variables.py b/tests/test_variables.py
index a02b2fc..bc46de9 100644
--- a/tests/test_variables.py
+++ b/tests/test_variables.py
@@ -107,7 +107,7 @@ class TestSimpleVariables(unittest.TestCase):  # {{{1
 
     def test_simple_variables_integeational(self):  # {{{2
         """Not exactly unittest but very usefull"""
-        doc = opendoc("tests/data/variables.odt")
+        doc = opendoc("tests/data/variables.fodt")
         self.assertTrue(isinstance(doc.body.variables,
                                    GenericWrapper))
         self.assertTrue(isinstance(doc.body.variables,

But I didn't dig into the test code, I let the addition of the test to read a ".fodt" document to someone else.

@jonadem jonadem changed the title 22 - Reenablesupport for Flat XML OpenDocumentFormat files 22 - Reenable support for Flat XML OpenDocumentFormat files Jul 26, 2017
@jonadem
Copy link
Author

jonadem commented Nov 13, 2018

Hello,

A feedback will be appreciated.

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant