Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-288: improve configuration of DesignSafe url #245

Merged

Conversation

nathanfranklin
Copy link
Collaborator

Overview:

This PR:

  • improve configuration of DesignSafe URL (WG-288)
  • fixes links to DS (WG-322)

PR Status:

  • Ready.

Related Jira tickets:

Testing Steps:

  1. Review code for WG-288 and also see that still works with DesignSafe next locally (and when deployed to /exp)
  2. For WG-322, see the links from maps connected to My Data (and maps connected to projects) work and open in new tab (see https://tacc-main.atlassian.net/browse/WG-322 screenshot of where this is in the UI).

Copy link
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I did not run the code locally.

@nathanfranklin nathanfranklin merged commit 59796c4 into feature/tapisv3 Jul 22, 2024
5 checks passed
@nathanfranklin nathanfranklin deleted the task/WG-288-improve-configuration-of-ds-url branch July 22, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants