Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task/WG-299-Update-User-Guide-Link #277

Merged
merged 3 commits into from
Oct 31, 2024
Merged

task/WG-299-Update-User-Guide-Link #277

merged 3 commits into from
Oct 31, 2024

Conversation

sophia-massie
Copy link
Contributor

@sophia-massie sophia-massie commented Oct 30, 2024 •
edited
Loading

Overview:

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  • Updates Hazmapper user guide link and opens in a new tab
  • Adds Taggit user guide to main page and opens in new tab

Testing Steps:

  1. Click user guide link and make sure it opens in a new tab

UI Photos:

Screenshot 2024-10-29 at 7 54 19 PM

Notes:

taoteg
taoteg approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nathanfranklin
nathanfranklin approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sophia-massie sophia-massie merged commit f89df63 into main Oct 31, 2024
5 checks passed
@sophia-massie sophia-massie deleted the task/WG-299-Update-User-Guide-Link branch October 31, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanfranklin nathanfranklin nathanfranklin approved these changes

@taoteg taoteg taoteg approved these changes

@shayanaijaz shayanaijaz Awaiting requested review from shayanaijaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sophia-massie @taoteg @nathanfranklin