Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian and docker build #683

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Debian and docker build #683

merged 5 commits into from
Jan 8, 2024

Conversation

surak
Copy link
Contributor

@surak surak commented Jan 4, 2024

As spoken at SC' 2023, this adds the necessary files for generating a Debian package in the debian/ directory.

It also has a docker/ directory which creates the .deb package inside a debian docker image. It was done this way so one can generate the Debian package always in a clean environment, and from non-debian machines (My workstation right now is a mac).

The workflow is simple:

cd docker
./build.sh

After a minute or two, there's a deb file with the latest tag from the "upstream" - in my case, set to https://github.com/TACC/Lmod.git.

This might need some adjustment in the docker file as it expects at least a branch called debian with the debian and docker directories to build itself there. Once this is on the master branch, this part is unnecessary.

I am talking about this: https://github.com/surak/Lmod/blob/4986506b836dfa9b6767f692830ecb907f864766/docker/Dockerfile#L44

@rtmclay rtmclay merged commit eb3e911 into TACC:main Jan 8, 2024
9 checks passed
@rtmclay
Copy link
Member

rtmclay commented Jan 8, 2024

Thanks for the patch!
Best
Robert

@wpoely86
Copy link
Contributor

wpoely86 commented Jan 9, 2024

I'm not familiar with the build process for debs but could we let this run as a github actions too @surak ?

@surak
Copy link
Contributor Author

surak commented Jan 9, 2024

I don’t see why not. The dockerfile should work. The only thing it does is to install the dependencies for building a package, clone Lmod, switch to the right tag, compile it with the Debian package maker, and the scirpt copies the deb file out of the container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants