Bug/WI-67: Logging and forcing tapis token retrieval on every request #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnets
approved these changes
Nov 2, 2023
| name: Build on push to bug/WI-67-connection-issues | ||
| on: | ||
| push: | ||
| branches: [ bug/WI-67-connection-issues ] |
There was a problem hiding this comment.
Should we maybe abstract this and create a "experiment" branch that we push changes like this to, instead of creating workflows for each unusual case like this?
|
|
||
| @app.before_request | ||
| def before_request_log(): | ||
| app.logger.info(f"{request.remote_addr} \"{request.method} {request.url}\"") |
There was a problem hiding this comment.
If the logging level is set to DEBUG shouldn't it be:
Suggested change
| app.logger.info(f"{request.remote_addr} \"{request.method} {request.url}\"") | |
| app.logger.debug(f"{request.remote_addr} \"{request.method} {request.url}\"") |
If we just want this log at the info level and available all the time in the logs, I'm fine with that too.
There was a problem hiding this comment.
Agree, will move it to DEBUG.
|
|
||
| @app.after_request | ||
| def after_request_log(response): | ||
| app.logger.info(f"{request.remote_addr} \"{request.method} {request.url}\" {response.status_code}") |
There was a problem hiding this comment.
Suggested change
| app.logger.info(f"{request.remote_addr} \"{request.method} {request.url}\" {response.status_code}") | |
| app.logger.debug(f"{request.remote_addr} \"{request.method} {request.url}\" {response.status_code}") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes
Testing
Test Results
Note: in test results, the exception handling messages are different based on how the report was authored. It is out of scope of the WMA to adjust report logic.