chore: tup-621 migrate css to core-styles - news #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
changed the title
wesleyboar
changed the title
wesleyboar
changed the title
wesleyboar
changed the title
14 tasks
* feat: tup-619 c-content block migration * removed content-block import
* migrated c-update to core-styles * removed c-update import
* feat: tup-624: added generics/attributes to demo * migrated rest of attributes.css to core-styles * removed unnecessary comments in css file for c-button
* getting rid of django.cms.blog.app.item.css * removing the import for django.cms.blog.app.item.css
Co-authored-by: Wesley Bomar <[email protected]>
Co-authored-by: Wesley Bomar <[email protected]>
WARNING: v2.17.3 causes login form field bug.
No need for u-highlight per jira ticket Co-authored-by: Wesley B <[email protected]>
Co-authored-by: Wesley Bomar <[email protected]>
* I believe this has already been merged into core-styles... Padding and Margin seem to be available on prod * remove import of core-styles o-heading-steps.css
* feat/tup-633: Migrate lightgallery to core-cms * delete unnecessary import of django.cms.picture.css
* feat/tup-629: delete footer Footer is already in core-styles and cms * remove unnecessary imports
* chore: migrate c-button styles to core-cms TACC/Core-CMS#729 * fix: remove import of file deleted in merge --------- Co-authored-by: Tomas Gonzalez <[email protected]>
WARNING: Introduces login form field width bug. (Core-Styles v2.17.3 might be the cause.)
* feat: tup-648 do not use plain highlight class * feat: tup-648 do not use plain highlight class
* bug/tup-650: Remove padding-block from cms * adjusted comments to relative code blocks
* fix: tup-654 use c-form--login from core-styles * chore: tup-654 remove redundant `c-form` classname
Some Core-Styles were loaded via CDN, cuz CMS did not have latest yet. Now CMS has much more recent Core-Styles, so use them. Do not duplicate.
* chore: tup-463 remove temp. core-styles imports Some Core-Styles were loaded via CDN, cuz CMS did not have latest yet. Now CMS has much more recent Core-Styles, so use them. Do not duplicate. * chore: tup-463 delete css modules mimicking core Some Core-Styles CSS was added after TUP login form was developed. Now that it is available, TUP lofin form can use it. Less module CSS! * style: npx nx format:write
Some Core-Styles CSS was added after TUP login page was developed. Now that it is available, TUP login page can use it. Less module CSS!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Migrate CSS to https://github.com/TACC/Core-Styles/.
To Do
Related
Changes
c-newsto match recent changes to Core-CMS's Django CMS Blog CSSthis is temporary record keeping; migration will remove these files from
tup-cmsTesting
UI
…