Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: cms v4.20 & core-styles v2.37 #487

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Oct 24, 2024

Overview

Fix styles bugs. Add styles features. Get some noop, coattailing updates.

Related

Changes

  • updated Core-Styles & Core-CMS

Testing & UI

✅ Core-CMS v4.18 / Core-Styles v2.35

  1. Visit https://tacc.utexas.edu/systems/all/.
  2. See extra space to the right of all images in cards. 🫢
  3. Visit https://dev.tup.tacc.utexas.edu/systems/all/.
  4. See no such space. 😏
Before After
before after

✅ Core-CMS v4.19 / Core-Styles v2.36

  1. Create a Bootstrap column.
  2. Choose "Column dark"
  3. Verify in that column;
    • background becomes dark
    • text becomes light
    • primary Button becomes lighter
    • Cards adapt as if in a dark Section
Before After
Screenshot 2024-10-25 at 7 27 16 PM Screenshot 2024-10-25 at 7 26 16 PM

✅ Core-CMS v4.20

  1. Create a "Section (…)".
    i.e. o-section
  2. Verify a <div class="o-section"> is created.
  3. Verify it does not have container class.
Plugin Render
Plugin Render

⚠️ Core-Styles v2.37

  1. Create/Find a c-card--plain that has an image.
    1. Create a "Style" block.
    2. Choose c-card--plain.
    3. Save block.
    4. Add "Picture/Image" block inside.
    5. Add "Text" block inside (with an <h3> and a paragraph).
  2. Edit the "Picture/Image": Add a link (internal or external).

  3. Save block.

  4. Verify card layout does not change.

    • ⚠️ Image crop changes.
  5. Verify image in card has hover and click state.

  6. Verify hover and click state are visible around image.

    • ⚠️ Border is only on 1 side of a card--right image.
add.link.to.card.image.mov
Before After After (Hover) After (Click)
before after after - hover after - active

@wesleyboar wesleyboar changed the title deps: core-cms v4.18.0, core-styles v2.35.1 fix: core-styles bug (cms v4.18, core-styles v2.35) Oct 24, 2024
@wesleyboar wesleyboar changed the title fix: core-styles bug (cms v4.18, core-styles v2.35) fix: core-styles bug (cms v4.19, core-styles v2.36) Oct 25, 2024
@wesleyboar wesleyboar changed the title fix: core-styles bug (cms v4.19, core-styles v2.36) deps: cms v4.19 & core-styles v2.36 Oct 25, 2024
@wesleyboar wesleyboar changed the title deps: cms v4.19 & core-styles v2.36 deps: cms v4.19 & core-styles v2.35 Oct 26, 2024
@wesleyboar wesleyboar changed the title deps: cms v4.19 & core-styles v2.35 deps: cms v4.20 & core-styles v2.37 Nov 1, 2024
fix cards with linekd images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant