Fixing problem with printing traces where reduction was disabled. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petergjoel
reviewed
Nov 21, 2023
| @@ -214,6 +214,8 @@ namespace PetriEngine { | |||
| transitions.push(p.second); | |||
| } | |||
|
|
|||
| auto reducer = builder->getReducer(); | |||
|
|
|||
There was a problem hiding this comment.
You probably want to avoid shadowing the member; introduce a new variable.
Also I think
reducer = reducer ? reducer : builder->getReducer();
Would be more sound; the reducer might already be set, and you may actually unset it.
There was a problem hiding this comment.
I updated the definition as suggested, but it should not make any change, as the reduced is set to builder if called.
petergjoel
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes the problem where CTL trace generator with disabled structural reductions didn't return the tokens in the trace, e.g. the bug report: https://bugs.launchpad.net/tapaal/+bug/2037313