Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpn unfolding - fix 2081147 #174

Merged
merged 9 commits into from
Nov 14, 2024
Merged

Conversation

mtygesen
Copy link
Contributor

@mtygesen mtygesen commented Oct 11, 2024

Fixes:
https://bugs.launchpad.net/tapaal/+bug/2081147

By adding a extra empty map if right most expr is a VariableExpression or a tuple expression with a VariableExpression

@srba srba self-requested a review October 11, 2024 13:13
@mtygesen mtygesen marked this pull request as ready for review October 11, 2024 13:13
@srba srba requested a review from petergjoel October 11, 2024 18:24
Copy link
Member

@petergjoel petergjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup of the code.
The fix looks correct - I am unsure if it fixes the more general problem.

The subtraction change looks a little funky.

src/PetriEngine/Colored/EvaluationVisitor.cpp Show resolved Hide resolved
include/PetriEngine/Colored/VariableVisitor.h Outdated Show resolved Hide resolved
include/PetriEngine/Colored/VariableVisitor.h Outdated Show resolved Hide resolved
include/PetriEngine/Colored/VariableVisitor.h Outdated Show resolved Hide resolved
include/PetriEngine/Colored/VariableVisitor.h Outdated Show resolved Hide resolved
include/PetriEngine/Colored/Expressions.h Outdated Show resolved Hide resolved
include/PetriEngine/Colored/Expressions.h Outdated Show resolved Hide resolved
@petergjoel
Copy link
Member

... but other than my comments, a nice change.

I have a hard time to determine if this fixes all the issues. But it has the right flavor to it (i.e. more general/relaxed in assumption about the structure of the colors).

@srba srba requested a review from petergjoel November 7, 2024 10:27
Copy link
Member

@srba srba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the bug and passes all the consistency and performance checks.

@srba srba merged commit cc8da4e into TAPAAL:main Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants