Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

order firmware groups in the dialog and in the code #4087

Merged
merged 1 commit into from
Oct 14, 2024
Merged

order firmware groups in the dialog and in the code #4087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/BizHawk.Client.EmuHawk/config/FirmwaresConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,13 @@ private void WarpToSystemId(string sysId)

private void FirmwaresConfig_Load(object sender, EventArgs e)
{
string GetSystemGroupName(string sysID) => SystemGroupNames.TryGetValue(sysID, out var name) ? name : "FIX ME (FirmwaresConfig.cs)";

ListViewGroup AddGroup(string sysID)
{
lvFirmwares.Groups.Add(
key: sysID,
headerText: SystemGroupNames.TryGetValue(sysID, out var name) ? name : "FIX ME (FirmwaresConfig.cs)");
headerText: GetSystemGroupName(sysID));
return lvFirmwares.Groups[lvFirmwares.Groups.Count - 1];
}

Expand All @@ -194,7 +196,7 @@ ListViewGroup AddGroup(string sysID)

// populate ListView from firmware DB
var groups = new Dictionary<string, ListViewGroup>();
foreach (var fr in FirmwareDatabase.FirmwareRecords)
foreach (var fr in FirmwareDatabase.FirmwareRecords.OrderBy(r => GetSystemGroupName(r.ID.System)))
{
var sysID = fr.ID.System;
var lvi = new ListViewItem
Expand Down
Loading