-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#995] added instructions for pulling main into dev branch #1028
[#995] added instructions for pulling main into dev branch #1028
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1028 +/- ##
==========================================
+ Coverage 97.32% 97.33% +0.01%
==========================================
Files 89 89
Lines 14964 15027 +63
==========================================
+ Hits 14563 14626 +63
Misses 401 401 ☔ View full report in Codecov by Sentry. |
@seanlaw I did my best here but couldn't quite get the drop down rendering as expected with 'myst-nb' any tips? |
@joehiggi1758 Let me take a look |
According to the top of this page, it says:
So, I'm guessing that we'll need to add the https://sphinx-togglebutton.readthedocs.io/en/latest/index.html#installation Would you mind trying that and seeing if it changes anything? |
@seanlaw yes thank you for the direction - I got it working!
|
Sorry that I missed this. In the future, rather than editing the existing comment, it would be helpful to start a new comment instead. This way, I get an email that something has changed and needs my attention. This will ensure that you will receive much timelier responses. I will try to review this ASAP. |
@seanlaw apologies - I'll do that next time, thanks for the understanding and direction here! |
@joehiggi1758 I think that the admonition should be like:
Specifically, you want to start/stop the admonition using triple colons and then this will allow you to actually have a proper code block using triple backticks. Otherwise, the "code" part, which is just what the command line prints out, doesn't look right. |
82b9b8c
to
bcf2604
Compare
@joehiggi1758 Thank you for adding this! |
@seanlaw my pleasure - as always, thank you for the opportunity and direction! |
Pull Request Checklist
Below is a simple checklist but please do not hesitate to ask for assistance!
black
(i.e.,python -m pip install black
orconda install -c conda-forge black
)flake8
(i.e.,python -m pip install flake8
orconda install -c conda-forge flake8
)pytest-cov
(i.e.,python -m pip install pytest-cov
orconda install -c conda-forge pytest-cov
)black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./
in the root stumpy directoryflake8 --extend-exclude=.venv ./
in the root stumpy directory./setup.sh dev && ./test.sh
in the root stumpy directory