-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dao): proposals list invalidation #1310
Conversation
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is an invalidation mechanism and it was working previously, you shouldn't have to pass this refetch
can you check the invalidateQueries
call instead please
This doesn't work here: https://github.com/TERITORI/teritori-dapp/blob/fix-refetch-proposal/packages/components/dao/ProposalActions.tsx#L118 |
okay, can you try to fix this then? |
I tried but I didn't succeed. |
Fixed properly |
…app into fix-refetch-proposal
Actually, we have to reload the page, after a proposal action, to see the new status.
This fix refetch the proposals correctly
Start
Let's click on Approve !
Without the fix, only the vote status is refreshed, not the whole proposal.
Here, we see the "Voted" gauge is still at "0"
With the fix, the proposal is refresh
Here, we see the fresh proposal status with the votes gauge "1/1" and so the Execute action is available