-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Make hash available in addition to CID when using IPFS #1311
Conversation
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
what is the purpose of this? I think you are putting twice the same data, this is costing gas for no benefit form what I understand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requesting change to prevent merging before clarification
I send a hash and not a CID to UploadMetadatas: Because, in the UploadMetadatas function, we VerifyPinned: My modification is stupid, I might as well adapt the service rather than change useIpfs, or maybe retrieve the hash from the CID |
closing, like discussed in sync: in all cases: we shouldn't modify this basic type that is used to publish data on-chain f you are passing the metadata.image field, which should be an ipfs uri, you need to strip the also be careful to always store ipfs uris ( |
Bad files types modifications ! |
Before
useIpfs
allows to get the CID of uploaded filesOur files types embed this CID as
url
After
useIpfs
allows to get the CID and the hash (before parsing it to CID) of uploaded filesOur files types embed the CID as
url
and the hash ashash