feat(file-uploader): move files + add required
prop + allow to clear from parent
#1314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real purpose of this PR
Better arborescence
Make
<Label isRequired
worksI've just added a
required
prop toFileUploader
. We considerFileUploader
as an "input". It has a Label and it is used in formsBONUS
Allow to clear the
input type='file'
inFileUploaderSmall
from a parent using a refNot used yet, but used in Launchpad PR (#1024).
We can remove that from this atomic PR if you want
Usage
The point with that is that we can clear the file visually, that's ok (React state). BUT the file is still in the
input type='file'
.So I've added this
resetFiles
cleaner.