Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add useDAOProposalById #1317

Merged
merged 6 commits into from
Oct 28, 2024
Merged

feat: add useDAOProposalById #1317

merged 6 commits into from
Oct 28, 2024

Conversation

WaDadidou
Copy link
Collaborator

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for testitori ready!

Name Link
🔨 Latest commit 670f92d
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/671ef014a1867b0008b7d361
😎 Deploy Preview https://deploy-preview-1317--testitori.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit 670f92d
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/671ef014ff78840008343f4a
😎 Deploy Preview https://deploy-preview-1317--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@n0izn0iz n0izn0iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should extract the conversion code instead of copying it

eg: create gnoToAppProposal and cosmwasmToAppProposal and use it in both "proposals" and "proposalById" hooks

@n0izn0iz n0izn0iz changed the title Feat: Add useDAOProposalById feat: add useDAOProposalById Oct 22, 2024
@WaDadidou
Copy link
Collaborator Author

I think we should extract the conversion code instead of copying it

eg: create gnoToAppProposal and cosmwasmToAppProposal and use it in both "proposals" and "proposalById" hooks

Done

@n0izn0iz n0izn0iz merged commit 163cbad into main Oct 28, 2024
21 of 22 checks passed
@n0izn0iz n0izn0iz deleted the feat-use-dao-proposal-by-id branch October 28, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants