fix: replaces useDropdowns by useClickOutside #883
Conversation
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sakul-budhathoki
requested review from
WaDadidou,
omniwired,
n0izn0iz and
clegirar
App.tsx
Outdated
| @@ -114,7 +114,7 @@ export default function App() { | |||
| </SearchBarContextProvider> | |||
| </WalletControlContextProvider> | |||
| </WalletsProvider> | |||
| </DropdownsContextProvider> | |||
| </ClickOutsideProvider> | |||
There was a problem hiding this comment.
How about "DropdownsClickOutsideProvider"; maybe is too long, but I feel that with the new name the original intent "Dropdown" got lost.
There was a problem hiding this comment.
Thanks for the idea, yes I agree we can achieve new changes without renames.
I can use:
ClickOutsideProvider -> DropdownsProvider
useClickOutside -> useDropdowns
So, we will have naming conventions as before, and it will be easier for devs to use this.
There was a problem hiding this comment.
Yep totally agree with that too 👍
packages/components/nfts/NFTView.tsx
Outdated
| @@ -118,10 +114,10 @@ export const NFTView: React.FC<{ | |||
|
|
|||
| const NFTViewContent: React.FC<{ | |||
| nft: NFT; | |||
| dropdownRef: RefObject<View>; | |||
|
|
|||
There was a problem hiding this comment.
This line is empty right ? If you can delete it 👍
sakul-budhathoki
force-pushed
the
refactor/replace-dropdowns-with-react-native-click-outside
branch
from
d255348
to
c008a09
Compare
sakul-budhathoki
force-pushed
the
refactor/replace-dropdowns-with-react-native-click-outside
branch
from
c008a09
to
e108ed3
Compare
n0izn0iz
changed the title
n0izn0iz
deleted the
refactor/replace-dropdowns-with-react-native-click-outside
branch
Problem:
Due to the use of Pressable on
DropdownsContextProvider, it blocks scroll ofScrollViewon mobile app (Android & iOS)Solution:
Replace
useDropdownsby react-native-click-outside