-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Support for edu-sharing Version < 7 and Script Refactoring #77
Open
Edmondi-Kacaj
wants to merge
109
commits into
master
Choose a base branch
from
develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove all edu-sharing version that are less than 7.0.0, - Throws error if the edu_version is less than 7.0.0,and stop the script for going further
1. delete all tasks related to the edu-sharing old/ version < 7.0.0 2. delete all files and templates related to old or version < 7.0.0
We don't need nginx anymore since, we don't want to install onloffice, and even if someone decide to do, we will use the docker version so no need of nginx server anymore.
Since the backup process is old and edu-sharing provide it's own backup and restore process then I will delete and implment a better solution for edu-sharing >= 7.0.0
Since the alfresco-solr4 role is not used anymore in edu-sharing version >=7, then is no need anymore to have it
We are not using any of databases localy since we switched to docker envioroment, so we don't need it anymore.
We are not using any of databases localy since we switched to docker envioroment, so we don't need it anymore.
Since now the rendering service come with edu-sharing in docker, we don't need anymore rendering service as host and role, it will be included automaticaly with edu-sharing
Onlyoffice role was not fully implmented, since it was a bug in edu-connector, and we decide to remove it
Java is used only for extracting/updating the amp files, so we will keep it. I implmented a better way of it, and I actiavted as default the java version 11
Tomcat is not used anymore, so we will remove it.
Keep the `install_splash: false` as it was before Co-authored-by: mirjan-hoffmann <[email protected]>
We will use geerlingguy.java role, we need java only for extract and zip again the amp file, so let's use tis role, and it will be maintained by other
we will use default-jdk for java, since we don't need java for any application to run, only to extract and compress the amp file, is ok to use default one
We will delete tomcat role in next pull reqeust since is used in other roles
if we run the vagrant only with edu-sharing tags then the java_home is not defined, so in this case we will check and if not then we will get from java role
we don't need this role anymore and for that reason we will delete it
moodle doesn't work for edu-sharing < 7, so in this case we will delete, and we need it we can reimplment it again
backup role, will go into optimization process, but for now let's remove, the lafresco part
Remove support for non docker versions (<7)
Migration role is executed only once, and after succesful migration, it will not be excecuted anymore so for that case is better to split from the edu-sharing and run as seperate role
we want to split the customization script into another role so in this case it will be more easy to maintain and work with it
we will split the classification keywords from edu-sharing core, and used it as a separate role in this case we work and run it as it's own role
Sometimes we need to reset or clean the elastics search index, and let the system re-index them again, so this commit will do exactly this thing
customize and override,the solr service
…ndition fix: add clean elastics search index
feat: add edu-sharing-search-solr
…nation folder, so we will ahve only one amp file, for alfviral and es-update-oersi
fix: update new es-update-oersi-1.0.1.amp
fix: Update version es_update_oersi_version: 1.0.2
looks like the edu-sharing will change the service name later, we made it adjustable so we can give an name according to the chnages from edu-sharing team, without modifying the code again
looks like the edu-sharing will change the service name later, we made it adjustable so we can give an name according to the chnages from edu-sharing team, without modifying the code again
looks like the edu-sharing will change the service name later, we made it adjustable so we can give an name according to the chnages from edu-sharing team, without modifying the code again
looks like the edu-sharing will change the service name later, we made it adjustable so we can give an name according to the chnages from edu-sharing team, without modifying the code again
Since we want to run and test the release candidate, we need to adjust the directory name according to the docker convetion
… creation Since in edu-sharing the image is different for release and release-candidat we made it dynamic, so we can run and install also the rc
…du-sharing-box into update-main.yml-file
* fix(edu-sharing-backup): Remove duplication and streamline edu-sharing-backup setup - Removed the duplicated 'set_fact' task for 'edu_docker_inst_dir'. - Applied 'edu-sharing-init' role with 'set_edu_docker_inst_dir' task to maintain consistency and reusability. --------- Co-authored-by: Hunar karim <[email protected]>
feat: Add edu-sharing version 9.0.0 version
fix: add version of es-update-oersi module (plugin)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @mirjan-hoffmann
In this pull request, I have made the following changes:
Removal of Support for edu-sharing Versions Below 7:
The codebase has been updated to no longer support versions of edu-sharing earlier than version 7. This change simplifies the maintenance and ensures we can take advantage of newer features and improvements in the latest versions of edu-sharing.
Refactoring and Optimization of Scripts:
Significant refactoring has been performed on various scripts to improve readability, maintainability, and efficiency.