New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fail test run with enabled junit.testFilter option #1361

Open

Sparkymann wants to merge 1 commit into TNG:main from Sparkymann:fix-failed-junit-tests-while-filtering

Sparkymann commented Oct 7, 2024 •

edited

Loading

Hi! There is a problem if you enable the junit.testFilter setting, and there are other tests in the project besides arch-unit
Exception:

Caused by: org.junit.platform.commons.PreconditionViolationException: cannot remove the root of a hierarchy

In PR fix a condition so that non-ArchUnit descriptors are not checked
Tested the changes in my test repository https://github.com/Sparkymann/archunit-test
Failed workflow: https://github.com/Sparkymann/archunit-test/pull/1/checks
Corrected: https://github.com/Sparkymann/archunit-test/pull/3/checks


          fix fail test run with enabled junit.testFilter option

7e3c820

nicholasgribanov approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet