improve rule to not fail for classes with no tests in their packages #1368
+37
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzysztof-owczarek
force-pushed
the
issue-1367-fix-multiple-impl-not-all-with-tests
branch
from
3012ef7
to
28c2894
Compare
hankem
reviewed
Oct 25, 2024
| @@ -0,0 +1,4 @@ | |||
| package com.tngtech.archunit.library.testclasses.packages.correct.twoimplementationsonetestdir1; | |||
|
|
|||
| public class OnlyOneImplementationHaveTestAndItIsMatchingImplPackageTest { | |||
There was a problem hiding this comment.
For your test to cover the use case of #1367, this should be
Suggested change
| public class OnlyOneImplementationHaveTestAndItIsMatchingImplPackageTest { | |
| class MultipleImplementationsWithOnlyOneTestAndInRightPackageTest { |
to make your new test actually fail with the old implementation. 🙂
In addition: I'd drop the AndInRightPackage part from this name: It's a relevant aspect to have classes with the same simple name in different packages, so: Is it right or is it wrong??
How about SimpleNameThatOccursInSeveralPackages?
There was a problem hiding this comment.
I was reneming classes at the end and forgot about that one 🤦 Thanks for this suggestion - applied!
…not all with tests Signed-off-by: krzysztof-owczarek <[email protected]>
Signed-off-by: krzysztof-owczarek <[email protected]>
krzysztof-owczarek
force-pushed
the
issue-1367-fix-multiple-impl-not-all-with-tests
branch
from
d494fc0
to
b87bd2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will improve the existing rule to test that test classes reside in the same package as their implementation. In particular the rule:
Should not fail if there are multiple test classes with the same simple name and some of the classes have no tests at all
Issue: #1367