New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in geqp3, made jpvt output 0-indexed #60

Merged

Wentzell merged 1 commit into TRIQS:unstable from jasonkaye:fix_jpvt_geqp3

Mar 5, 2024

Collaborator

jasonkaye commented Mar 5, 2024

Output jpvt of geqp3, taken directly from fortran, was 1-indexed. I converted it to 0-indexing to avoid confusion.


          in geqp3, made jpvt output 0-indexed

87f5155

jasonkaye requested a review from Wentzell

March 5, 2024 00:46

Wentzell approved these changes

View reviewed changes

Member

Wentzell left a comment

Thank you @jasonkaye for this improvement!

Wentzell merged commit 802f8dd into TRIQS:unstable

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet