Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the mixing to bring in more consistency, now there is a single linear/broyden mixing scheme that can mix either the Sigma or the G0.
There is a small difference at the bookeeping level for the broyden mixing from last implementation (the number of iterations was off by one for some reason) so in the current implementation broy_max_it = 7 is equivalent to the previous broy_max_it=8.
I also added a counter that gets written to the h5 achive which counts the CSC steps, this is to signal to quantum espresso how many mixing steps it should include in the DFT charge density mixing (separate PR for QE will arrive, at the moment this update is also compatible with the previous QE versions)
There is also an added flag which allows one to perform the G update every impurity iteration instead of computing all impurities and then updating. Overall this adds 4 flags in the read_config:
"""
'update_mu_each_imp': {'converter': BOOL_PARSER,
'used': True, 'default': False},
""
which take place of the previous G0 and Sigma mixing related flags.
The code still needs a little bit of cleaning (removing commented out code and adding description of new flags in the read config)