Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] fix null-pointer-exception in AbstractStrategy #3733

Conversation

adamkoppede
Copy link
Contributor

What this pr does

Fixes a null-pointer-exception that occurred when the "page type" field of a hidden root page was changed.

How to test

We weren't able to re-create the issue on a mirrored instance, since the corresponding index-queue item could not be created via the "Index Queue" TYPO3 backend module. We directly imported the database record for reproduction. It's possible that such an item cannot be created during normal operations.

We checked the patch on TYPO3 11 with PHP 8 against the 11.5.3 release.

Our indexing-queue contained an item for a hidden root page, that hasn't
been localized yet. When updating the hidden root page, the determined
site for the index queue item
in AbstractStrategy::deleteIndexDocuments() is null, which triggers
a PHP-Runtime error when getSolrConfiguration() is called on it.

We weren't able to figure out how this item ended up in the queue,
and we also weren't able to add it manually using the
"Index Queue" TYPO3 backend module.

Our instance was a TYPO3 11 with solr 11.5.3.
@dkd-kaehm
Copy link
Collaborator

Was fixed in #3770 and ported to 11.5.x in #3778

@dkd-kaehm dkd-kaehm closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants