[BUGFIX] fix null-pointer-exception in AbstractStrategy #3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our indexing-queue contained an item for a hidden root page, that hasn't been localized yet. When updating the hidden root page, the determined site for the index queue item in AbstractStrategy::deleteIndexDocuments() is null, which triggers a PHP-Runtime error when getSolrConfiguration() is called on it. We weren't able to figure out how this item ended up in the queue, and we also weren't able to add it manually using the "Index Queue" TYPO3 backend module. Our instance was a TYPO3 11 with solr 11.5.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
Fixes a null-pointer-exception that occurred when the "page type" field of a hidden root page was changed.
How to test
We weren't able to re-create the issue on a mirrored instance, since the corresponding index-queue item could not be created via the "Index Queue" TYPO3 backend module. We directly imported the database record for reproduction. It's possible that such an item cannot be created during normal operations.
We checked the patch on TYPO3 11 with PHP 8 against the 11.5.3 release.