-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!!![TASK] Relax dependencies to local tables #3764
Merged
dkd-kaehm
merged 4 commits into
TYPO3-Solr:main
from
dkd-friedrich:task/main/3763-relax_dependency_to_local_tables
Sep 15, 2023
Merged
!!![TASK] Relax dependencies to local tables #3764
dkd-kaehm
merged 4 commits into
TYPO3-Solr:main
from
dkd-friedrich:task/main/3763-relax_dependency_to_local_tables
Sep 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkd-friedrich
force-pushed
the
task/main/3763-relax_dependency_to_local_tables
branch
2 times, most recently
from
August 22, 2023 15:24
f867036
to
8cdd908
Compare
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Aug 22, 2023
As there may be several indexing configurations per type the queue check has to consider the indexing configuration. The missing check is added by this commit. Ports: TYPO3-Solr#3764 Resolves: TYPO3-Solr#3763
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Aug 22, 2023
As an initial steps to allow custom index queue types interfaces for queue and queue items are introduced. Additionally custom queue classes can be configured via: plugin.tx_solr.index.queue.<configurationName>.indexQueue This is a breaking change for all instances that implemented own queues and queue items! Ports: TYPO3-Solr#3764 Resolves: TYPO3-Solr#3763
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Aug 22, 2023
Queue initialization status returned by the QueueInitializationService isn't considered in the backend module and a success message is always shown. This commit adds a check for the returned status and displays an error message similiar to the message that is shown if an exceptions occured. Ports: TYPO3-Solr#3764 Resolves: TYPO3-Solr#3763
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Aug 22, 2023
Existing exceptions are now based on the recently introduced generic EXT:solr exception. Additionally based on the new generic EXT:solr exception a further exception is introduced, allowing more targeted handling of exceptions: InvalidIndexQueueInitizalizationPostProcessorException This is a breaking change as the base excepion changed and the new exception is no longer based on \UnexpectedValueException. Ports: TYPO3-Solr#3764 Resolves: TYPO3-Solr#3763
dkd-kaehm
changed the title
[TASK] Relax dependencies to local tables
!!![TASK] Relax dependencies to local tables
Sep 15, 2023
As there may be several indexing configurations per type the queue check has to consider the indexing configuration. The missing check is added by this commit. Resolves: TYPO3-Solr#3763
As an initial steps to allow custom index queue types interfaces for queue and queue items are introduced. Additionally custom queue classes can be configured via: plugin.tx_solr.index.queue.<configurationName>.indexQueue This is a breaking change for all instances that implemented own queues and queue items! Resolves: TYPO3-Solr#3763
Queue initialization status returned by the QueueInitializationService isn't considered in the backend module and a success message is always shown. This commit adds a check for the returned status and displays an error message similiar to the message that is shown if an exceptions occured. Resolves: TYPO3-Solr#3763
Existing exceptions are now based on the recently introduced generic EXT:solr exception. Additionally based on the new generic EXT:solr exception a further exception is introduced, allowing more targeted handling of exceptions: InvalidIndexQueueInitizalizationPostProcessorException This is a breaking change as the base excepion changed and the new exception is no longer based on \UnexpectedValueException. Resolves: TYPO3-Solr#3763
dkd-kaehm
force-pushed
the
task/main/3763-relax_dependency_to_local_tables
branch
from
September 15, 2023 07:39
8cdd908
to
cf5d5e5
Compare
dkd-kaehm
approved these changes
Sep 15, 2023
dkd-kaehm
deleted the
task/main/3763-relax_dependency_to_local_tables
branch
September 15, 2023 10:55
dkd-kaehm
pushed a commit
that referenced
this pull request
Sep 15, 2023
As an initial steps to allow custom index queue types interfaces for queue and queue items are introduced. Additionally custom queue classes can be configured via: plugin.tx_solr.index.queue.<configurationName>.indexQueue This is a breaking change for all instances that implemented own queues and queue items! Ports: #3764 Resolves: #3763
dkd-kaehm
pushed a commit
that referenced
this pull request
Sep 15, 2023
Queue initialization status returned by the QueueInitializationService isn't considered in the backend module and a success message is always shown. This commit adds a check for the returned status and displays an error message similiar to the message that is shown if an exceptions occured. Ports: #3764 Resolves: #3763
dkd-kaehm
pushed a commit
that referenced
this pull request
Sep 15, 2023
Existing exceptions are now based on the recently introduced generic EXT:solr exception. Additionally based on the new generic EXT:solr exception a further exception is introduced, allowing more targeted handling of exceptions: InvalidIndexQueueInitizalizationPostProcessorException This is a breaking change as the base excepion changed and the new exception is no longer based on \UnexpectedValueException. Ports: #3764 Resolves: #3763
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Sep 15, 2023
Fixes regression after TYPO3-Solr#3764
dkd-kaehm
pushed a commit
that referenced
this pull request
Nov 8, 2023
As an initial steps to allow custom index queue types interfaces for queue and queue items are introduced. Additionally custom queue classes can be configured via: plugin.tx_solr.index.queue.<configurationName>.indexQueue This is a breaking change for all instances that implemented own queues and queue items! Ports: #3764 Resolves: #3763
dkd-kaehm
pushed a commit
that referenced
this pull request
Nov 8, 2023
Queue initialization status returned by the QueueInitializationService isn't considered in the backend module and a success message is always shown. This commit adds a check for the returned status and displays an error message similiar to the message that is shown if an exceptions occured. Ports: #3764 Resolves: #3763
dkd-kaehm
pushed a commit
that referenced
this pull request
Nov 8, 2023
Existing exceptions are now based on the recently introduced generic EXT:solr exception. Additionally based on the new generic EXT:solr exception a further exception is introduced, allowing more targeted handling of exceptions: InvalidIndexQueueInitizalizationPostProcessorException This is a breaking change as the base excepion changed and the new exception is no longer based on \UnexpectedValueException. Ports: #3764 Resolves: #3763
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Mar 11, 2024
As there may be several indexing configurations per type the queue check has to consider the indexing configuration. The missing check is added by this commit. Ports: TYPO3-Solr#3764 Resolves: TYPO3-Solr#3763
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Mar 11, 2024
As an initial steps to allow custom index queue types interfaces for queue and queue items are introduced. Additionally custom queue classes can be configured via: plugin.tx_solr.index.queue.<configurationName>.indexQueue This is a breaking change for all instances that implemented own queues and queue items! Ports: TYPO3-Solr#3764 Resolves: TYPO3-Solr#3763
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Mar 11, 2024
Queue initialization status returned by the QueueInitializationService isn't considered in the backend module and a success message is always shown. This commit adds a check for the returned status and displays an error message similiar to the message that is shown if an exceptions occured. Ports: TYPO3-Solr#3764 Resolves: TYPO3-Solr#3763
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Mar 11, 2024
Existing exceptions are now based on the recently introduced generic EXT:solr exception. Additionally based on the new generic EXT:solr exception a further exception is introduced, allowing more targeted handling of exceptions: InvalidIndexQueueInitizalizationPostProcessorException This is a breaking change as the base excepion changed and the new exception is no longer based on \UnexpectedValueException. Ports: TYPO3-Solr#3764 Resolves: TYPO3-Solr#3763
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Mar 13, 2024
As an initial steps to allow custom index queue types interfaces for queue and queue items are introduced. Additionally custom queue classes can be configured via: plugin.tx_solr.index.queue.<configurationName>.indexQueue This is a breaking change for all instances that implement own queues and queue items! Ports: TYPO3-Solr#3764 Resolves: TYPO3-Solr#3763
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Mar 13, 2024
Queue initialization status returned by the QueueInitializationService isn't considered in the backend module and a success message is always shown. This commit adds a check for the returned status and displays an error message similiar to the message that is shown if an exceptions occured. Ports: TYPO3-Solr#3764 Resolves: TYPO3-Solr#3763
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Mar 13, 2024
Existing exceptions are now based on the recently introduced generic EXT:solr exception. Additionally based on the new generic EXT:solr exception a further exception is introduced, allowing more targeted handling of exceptions: InvalidIndexQueueInitizalizationPostProcessorException This is a breaking change as the base excepion changed and the new exception is no longer based on \UnexpectedValueException. Ports: TYPO3-Solr#3764 Resolves: TYPO3-Solr#3763
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Oct 30, 2024
As there may be several indexing configurations per type the queue check has to consider the indexing configuration. The missing check is added by this commit. Ports: TYPO3-Solr#3764 Resolves: TYPO3-Solr#3763
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Oct 30, 2024
As an initial steps to allow custom index queue types interfaces for queue and queue items are introduced. Additionally custom queue classes can be configured via: plugin.tx_solr.index.queue.<configurationName>.indexQueue This is a breaking change for all instances that implement own queues and queue items! Ports: TYPO3-Solr#3764 Resolves: TYPO3-Solr#3763
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Oct 30, 2024
Queue initialization status returned by the QueueInitializationService isn't considered in the backend module and a success message is always shown. This commit adds a check for the returned status and displays an error message similiar to the message that is shown if an exceptions occured. Ports: TYPO3-Solr#3764 Resolves: TYPO3-Solr#3763
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Oct 30, 2024
Existing exceptions are now based on the recently introduced generic EXT:solr exception. Additionally based on the new generic EXT:solr exception a further exception is introduced, allowing more targeted handling of exceptions: InvalidIndexQueueInitizalizationPostProcessorException This is a breaking change as the base excepion changed and the new exception is no longer based on \UnexpectedValueException. Ports: TYPO3-Solr#3764 Resolves: TYPO3-Solr#3763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
To allow indexing of external data the dependencies to local tables are relaxed, 4 steps are prepared to achieve this:
Most of these changes are breaking, as internal interfaces and exceptions are changed, that might be used outside of EXT:solr.
How to test
This changes just prepares EXT:solr for indexing of external data, the current behaviour is not changed!
Resolves: #3763