[BUGFIX] Do not index translations on default language fallbackType: free #3785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abohntek
reviewed
Sep 18, 2023
dkd-kaehm
approved these changes
Sep 18, 2023
dkd-kaehm
pushed a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Sep 18, 2023
…ree mode With fallbackType: free the index queue contains an entry for each available language. Without this check all the entries are additionally indexed in the default language. They should be only indexed for the language, the record has defined as sys_language_uid. Fixes TYPO3-Solr#3560 Ports: TYPO3-Solr#3785
…ree mode With fallbackType: free the index queue contains an entry for each available language. Without this check all the entries are additionally indexed in the default language. They should be only indexed for the language, the record has defined as sys_language_uid. Fixes TYPO3-Solr#3560
dkd-friedrich
pushed a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Sep 20, 2023
…guages free mode With fallbackType: free the index queue contains an entry for each available language. Without this check all the entries are additionally indexed in the default language. They should be only indexed for the language, the record has defined as sys_language_uid. Fixes TYPO3-Solr#3560 Ports: TYPO3-Solr#3785
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
With fallbackType: free the index queue contains an entry for each available language. Without this check all the entries are additionally indexed in the default language. They should be only indexed for the language, the record has defined as sys_language_uid.
See extensive debuggin in the issue.
How to test
Have a record based indexing configuration and change
fallbackTypetofreein your site config. Do not set anyfallbacksFixes #3560