!!![CLEANUP] Remove obsolete TYPO3 registry usages #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TYPO3 registry was mainly used for connection storage, which is obsolete since the introduction of the Site handling. Luke limit read by the InfoModuleController was never set in the registry, so for now the fallback value of 20000 is used. This is a breaking change as the SiteRepository expected the registry to be passed, which is no longer necessary. Resolves: TYPO3-Solr#3792
dkd-friedrich
force-pushed
the
task/main/3792-remove_obsolete_registry_usages
branch
from
993d1ee
to
8b55abb
Compare
dkd-friedrich
deleted the
task/main/3792-remove_obsolete_registry_usages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
TYPO3 registry was mainly used for connection storage, which is obsolete since the introduction of the Site handling. Luke limit read by the InfoModuleController was never set in the registry, so for now the fallback value of 20000 is used.
This is a breaking change as the SiteRepository expected the registry to be passed, which is no longer necessary.
Resolves: #3792