bug fix: Fixed id for other credential other than EBSIV2

TalaoDAO · Aug 9, 2023 · 621f0f6 · 621f0f6
1 parent 1ab5f4a
commit 621f0f6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/lib/app/shared/enum/type/credential_subject_type/credential_subject_type_extension.dart b/lib/app/shared/enum/type/credential_subject_type/credential_subject_type_extension.dart
@@ -259,8 +259,7 @@ extension CredentialSubjectTypeExtension on CredentialSubjectType {
       case CredentialSubjectType.residentCard:
         return 'ResidentCard';
       case CredentialSubjectType.employeeCredential:
-        //return 'EmployeeCredential';
-        return 'https://raw.githubusercontent.com/walt-id/waltid-ssikit-vclib/master/src/test/resources/schemas/ParticipantCredential.json';
+        return 'EmployeeCredential';
       case CredentialSubjectType.selfIssued:
         return 'SelfIssued';
       case CredentialSubjectType.studentCard:

diff --git a/lib/oidc4vc/add_oidc4vc_credential.dart b/lib/oidc4vc/add_oidc4vc_credential.dart
@@ -46,9 +46,12 @@ Future<void> addOIDC4VCCredential(
 
   newCredential['credentialPreview'] = credentialFromOIDC4VC;
 
-  /// added id as type to recognise the card
-  newCredential['credentialPreview']['credentialSubject']['type'] =
-      credentialFromOIDC4VC['credentialSchema']['id'];
+  if (oidc4vcType == OIDC4VCType.EBSIV2) {
+    /// added id as type to recognise the card
+    /// for ebsiv2 only
+    newCredential['credentialPreview']['credentialSubject']['type'] =
+        credentialFromOIDC4VC['credentialSchema']['id'];
+  }
 
   final CredentialManifest credentialManifest = await getCredentialManifest(
     Dio(),

diff --git a/lib/oidc4vc/initiate_oidv4vc_credential_issuance.dart b/lib/oidc4vc/initiate_oidv4vc_credential_issuance.dart
@@ -148,6 +148,8 @@ Future<void> getAndAddCredential({
       privateKey,
     );
 
+    print(encodedCredentialFromOIDC4VC);
+
     await addOIDC4VCCredential(
       encodedCredentialFromOIDC4VC,
       uriFromScannedResponse,