Fix: Prevent parent service to substract paid_to days

With my childservice paymentlogic user could see increase of paid_to date. For example with initial transaction extradays are added to parent and chid services. It could be that shildservice after next payment is paid more to future than new transaction gives. This commit fixes that. Signed-off-by: Erkki Hietaranta <[email protected]>
TampereHacklab · Mar 5, 2024 · 96f7736 · 96f7736
1 parent d207e86
commit 96f7736
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/utils/businesslogic.py b/utils/businesslogic.py
@@ -454,6 +454,7 @@ def _service_paid_by_transaction(servicesubscription, transaction, add_days):
                 else:
                     added_days = servicesubscription.paid_until - transaction.date
                     child_days = 0
+                    # check if and howmuch forehand child servce is paid
                     if paid_servicesubscription.paid_until:
                         if paid_servicesubscription.paid_until > transaction.date:
                             child_date = (
@@ -476,6 +477,13 @@ def _service_paid_by_transaction(servicesubscription, transaction, add_days):
                             - {child_days}
                             = gained {extra_days} days more"""
                     )
+
+                    if extra_days < 0:
+                        logger.debug(
+                            "Gained days are negative, using previous paid to date"
+                        )
+                        extra_days = 0
+
                     # Calculate child subscription payment to happen at same time that latest parrent subsciption,
                     # useful with custominvoices that pays Parent subscription multiple times
                     BusinessLogic._service_paid_by_transaction(