Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'datas' to 'mealData' #114

Closed
wants to merge 1 commit into from
Closed

Rename 'datas' to 'mealData' #114

wants to merge 1 commit into from

Conversation

utilForever
Copy link

@utilForever utilForever commented Aug 7, 2024 •
edited
Loading

This revision includes:

  • Rename 'datas' to 'mealData'
    • 'Data' is the plural of 'Datum', so 'Datas' is not quite right - 'mealData' looks better in terms of readability.
    • BTW, Data takes a singular verb (like agenda), though strictly a plural; no one ever uses "agendum" or "datum" in Guardian style guide.
    • Therefore, you may or may not merged this PR.

Mercen-Lee
Mercen-Lee approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@Mercen-Lee Mercen-Lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! 👍

@hhhello0507
Copy link
Contributor

hhhello0507 commented Aug 13, 2024 •
edited
Loading

We have modified the MealView.swift file and no longer use the datas variable. Your issue has been closed. Sorry. 😢 @utilForever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mercen-Lee Mercen-Lee Mercen-Lee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@utilForever @hhhello0507 @Mercen-Lee