[refactor] findByUserIdAndRecordId로 함수 이름 변경

Team-Recordy · Jul 12, 2024 · b5c3ad3 · b5c3ad3
1 parent 937ae3c
commit b5c3ad3
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/src/main/java/org/recordy/server/record_stat/repository/BookmarkRepository.java b/src/main/java/org/recordy/server/record_stat/repository/BookmarkRepository.java
@@ -17,5 +17,5 @@ public interface BookmarkRepository {
 
     //query
     Slice<Bookmark> findAllByBookmarksOrderByIdDesc(long userId, long cursor, Pageable pageable);
-    Optional<Bookmark> findByUserAndRecord(long userId, long recordId);
+    Optional<Bookmark> findByUserIdAndRecordId(long userId, long recordId);
 }
diff --git a/src/main/java/org/recordy/server/record_stat/repository/impl/BookmarkRepositoryImpl.java b/src/main/java/org/recordy/server/record_stat/repository/impl/BookmarkRepositoryImpl.java
@@ -47,7 +47,7 @@ public void deleteById(long bookmarkId) {
     }
 
     @Override
-    public Optional<Bookmark> findByUserAndRecord(long userId, long recordId) {
+    public Optional<Bookmark> findByUserIdAndRecordId(long userId, long recordId) {
         return bookmarkJpaRepository.findByUser_IdAndRecord_Id(userId, recordId)
                 .map(BookmarkEntity::toDomain);
     }

diff --git a/src/main/java/org/recordy/server/record_stat/service/impl/RecordStatServiceImpl.java b/src/main/java/org/recordy/server/record_stat/service/impl/RecordStatServiceImpl.java
@@ -40,7 +40,7 @@ public Bookmark bookmark(long userId, long recordId) {
 
     @Override
     public void deleteBookmark(long userId, long recordId) {
-        Optional<Bookmark> optionalBookmark = bookmarkRepository.findByUserAndRecord(userId, recordId);
+        Optional<Bookmark> optionalBookmark = bookmarkRepository.findByUserIdAndRecordId(userId, recordId);
         if (optionalBookmark.isPresent()) {
             Bookmark bookmark = optionalBookmark.get();
             bookmarkRepository.deleteById(bookmark.getId());

diff --git a/src/test/java/org/recordy/server/mock/bookmark/FakeBookmarkRepository.java b/src/test/java/org/recordy/server/mock/bookmark/FakeBookmarkRepository.java
@@ -51,7 +51,7 @@ public Slice<Bookmark> findAllByBookmarksOrderByIdDesc(long userId, long cursor,
     }
 
     @Override
-    public Optional<Bookmark> findByUserAndRecord(long userId, long recordId) {
+    public Optional<Bookmark> findByUserIdAndRecordId(long userId, long recordId) {
         return bookmarks.values().stream()
                 .filter(bookmark -> bookmark.getUser().getId() == userId && bookmark.getRecord().getId() == recordId)
                 .findFirst();

diff --git a/...est/java/org/recordy/server/record_stat/repository/BookmarkRepositoryIntegrationTest.java b/...est/java/org/recordy/server/record_stat/repository/BookmarkRepositoryIntegrationTest.java
@@ -121,7 +121,7 @@ public class BookmarkRepositoryIntegrationTest extends IntegrationTest {
         //given
 
         //when
-        Bookmark bookmark = bookmarkRepository.findByUserAndRecord(1,1).get();
+        Bookmark bookmark = bookmarkRepository.findByUserIdAndRecordId(1,1).get();
 
         //then
         assertAll(