-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] MyPageView 수정사항 반영 #162
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
비즈니스 로직이 많아서 분리의 필요성을 느끼고, 구현 할 자신이 있다면 VIewModel을 사용할 수 있지 않을까요?? (개인적인 생각)
고생하셨습닌다 화이팅
|
||
public override func layoutSubviews() { | ||
super.layoutSubviews() | ||
layer.cornerRadius = bounds.height / 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p2
height 쓰는 부분에 .adaptiveHeight 필요할 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 다른 height 부분에도 수정 필요해요
let paragraphStyle = NSMutableParagraphStyle() | ||
paragraphStyle.lineSpacing = 30 - $0.font.lineHeight | ||
paragraphStyle.alignment = .center |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3
UILabel+에 선언돼있는 lineSpacing 설정 함수를 사용하지 않은 이유가 있나요 ??
[ | ||
imageView, | ||
titleLabel, | ||
goAroundButton | ||
].forEach { addSubview($0) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3
addSubviews 써도 좋을 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다른 View / VIewController에도 수정 필요해요
func setActionButtonHandler(_ handler: @escaping () -> Void) { | ||
goAroundButton.addTarget(self, action: #selector(actionButtonTapped), for: .touchUpInside) | ||
self.actionButtonHandler = handler | ||
} | ||
|
||
@objc private func actionButtonTapped() { | ||
actionButtonHandler?() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3
actionButtonTapped()애서 동작을 정의하지 않고, setActionButtonHandler()로 클로저를 통해 동작을 전달하는 이유가 있나요 ??
🔍 PR Content
📸 Screenshot
2024-10-19.03.11.26.mov
📍 PR Point
✏️ Notice
ViskitYellowButton 컴포넌트
goAroundButton.do { $0.setTitle("영상 둘러보기", for: .normal) }
와 같이 타이틀만 정의해서 사용해주시면 됩니다.
🙏 To Reviewers
다음 작업을 위해 고민하던 중에, 현재 profileViewController에 데이터 바인딩 로직이 전부 존재하는데, 이를 저번에 viewModel은 가급적 사용하지 말라고 하셨던 기억이 있어서 어떻게 분리를 해주면 좋을지 조언 부탁드립니다!
resolved [Refactor] MyPageView 구현 #159