[Refactor] MyPageView 수정사항 반영 #162
Open
+404
−495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chandrarla
reviewed
Oct 25, 2024
|
|
||
| public override func layoutSubviews() { | ||
| super.layoutSubviews() | ||
| layer.cornerRadius = bounds.height / 2 |
There was a problem hiding this comment.
p2
height 쓰는 부분에 .adaptiveHeight 필요할 것 같습니다!
There was a problem hiding this comment.
- 다른 height 부분에도 수정 필요해요
Comment on lines
+46
to
+48
| let paragraphStyle = NSMutableParagraphStyle() | ||
| paragraphStyle.lineSpacing = 30 - $0.font.lineHeight | ||
| paragraphStyle.alignment = .center |
There was a problem hiding this comment.
p3
UILabel+에 선언돼있는 lineSpacing 설정 함수를 사용하지 않은 이유가 있나요 ??
Comment on lines
+68
to
+72
| [ | ||
| imageView, | ||
| titleLabel, | ||
| goAroundButton | ||
| ].forEach { addSubview($0) } |
There was a problem hiding this comment.
p3
addSubviews 써도 좋을 것 같아요!
There was a problem hiding this comment.
다른 View / VIewController에도 수정 필요해요
Comment on lines
+97
to
+104
| func setActionButtonHandler(_ handler: @escaping () -> Void) { | ||
| goAroundButton.addTarget(self, action: #selector(actionButtonTapped), for: .touchUpInside) | ||
| self.actionButtonHandler = handler | ||
| } | ||
|
|
||
| @objc private func actionButtonTapped() { | ||
| actionButtonHandler?() | ||
| } |
There was a problem hiding this comment.
p3
actionButtonTapped()애서 동작을 정의하지 않고, setActionButtonHandler()로 클로저를 통해 동작을 전달하는 이유가 있나요 ??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 PR Content
📸 Screenshot
2024-10-19.03.11.26.mov
📍 PR Point
✏️ Notice
ViskitYellowButton 컴포넌트
goAroundButton.do { $0.setTitle("영상 둘러보기", for: .normal) }와 같이 타이틀만 정의해서 사용해주시면 됩니다.
🙏 To Reviewers
다음 작업을 위해 고민하던 중에, 현재 profileViewController에 데이터 바인딩 로직이 전부 존재하는데, 이를 저번에 viewModel은 가급적 사용하지 말라고 하셨던 기억이 있어서 어떻게 분리를 해주면 좋을지 조언 부탁드립니다!
resolved [Refactor] MyPageView 구현 #159