[Refac] atoms 컴포넌트 리팩토링 #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eugene028
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Describe your changes
atoms 컴포넌트들에서 분리가 필요한 부분(단순 상수값, 타입 정보)이 있어 리팩토링했습니다.
이때 타입을 명확하게 지정해주지 않은 정보도 명확하게 지정해주었습니다.
To Reviewers
기존 apis 폴더 내부 types 폴더에서 타입을 관리했었는데 src > models 폴더를 새로 생성했습니다.
타입 정보는 밖으로 빼는 게 더 좋은 것 같습니다.
추후 다른 부분 리팩토링하면서 그 부분도 같이 옮기면 좋을 거 같네요.