Feat : FCM 연동 및 테스트 #192
Merged
Feat : FCM 연동 및 테스트 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiwoo-jo
approved these changes
Mar 25, 2024
| "api_key": [ | ||
| { | ||
| "current_key": "AIzaSyDAlGMqpZY_g9oyw3SHkxm-Ke5Qw5MKEsc" | ||
| "current_key": "AIzaSyCAnvMxwnN_XBoZJPv8Ob3oB4qTz_ILtnA" |
There was a problem hiding this comment.
current_key는 숨김처리 안해도 되는건가요?
There was a problem hiding this comment.
이 파일 자체를 숨겨야 하나 말아야 하나 고민했는데 firebase 공식 문서에서 굳이 숨기지 않아도 된다 라는 글을 봤어가지구 안 숨겼어요!!
대신에 파이어 베이스를 보안화 해야 한다는 (..) 뭐 그런 내용을 봤습니다.
참고 이슈도 있길래 첨부합니당
Comment on lines
+38
to
41
| // Intent 및 PendingIntent 생성 | ||
| val intent = Intent(this, MainActivity::class.java).apply { | ||
| flags = Intent.FLAG_ACTIVITY_CLEAR_TOP or Intent.FLAG_ACTIVITY_SINGLE_TOP | ||
| } |
There was a problem hiding this comment.
전에 말씀하셨던 intent 캡슐화를 했는데 나중에 수정하는게 좋을까요?
There was a problem hiding this comment.
아 그 캡슐화 바로 진행해주실 줄 몰라서 ㅋㅋㅋㅋ 지금 전체적으로 intent 객체를 보내는 곳에서 만들고 있을 거라 다 수정해야 할 것 같아요 일단 요 부분 수정하고 나중에 코드 일관성있게 다 수정 해야 할 듯 합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📮 관련 이슈
✍️ 구현 내용
📷 구현 영상
✔️ 확인 사항