Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for v0.3 #232

Open
wants to merge 8 commits into
base: prepare-v03
Choose a base branch
from
Open

Update tests for v0.3 #232

wants to merge 8 commits into from

Conversation

shinich1
Copy link
Contributor

@shinich1 shinich1 commented Nov 4, 2024

Before submitting, please check the following:

  • Make sure you have tests for the new code and that test passes (run nox)
  • If applicable, add a line to the [unreleased] part of CHANGELOG.md, following keep-a-changelog.
  • Format added code by ruff
    • See CONTRIBUTING.md for more details
  • Make sure the checks (github actions) pass.
  • Check that the docs compile without errors (run make html in ./docs/ - you may need to install dependency for sphinx docs, see docs/requirements.txt.)

Then, please fill in below:

Context (if applicable):

Fix tests to account for the deprecations.

Description of the change:

  • fixed test_pattern, test_transpiler. rename pattern.standardize, pattern.shift_signals argument names.
  • removed CommandNode class which should also be deprecated.

Related issue:

@shinich1 shinich1 changed the title update tests Update tests for v0.3 Nov 4, 2024
@shinich1 shinich1 marked this pull request as ready for review November 4, 2024 14:43
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (prepare-v03@3163e10). Learn more about missing BASE report.

Files with missing lines Patch % Lines
graphix/pattern.py 62.50% 3 Missing ⚠️
graphix/graphsim/rxgraphviews.py 66.66% 1 Missing ⚠️
graphix/sim/density_matrix.py 50.00% 1 Missing ⚠️
graphix/sim/statevec.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             prepare-v03     #232   +/-   ##
==============================================
  Coverage               ?   75.32%           
==============================================
  Files                  ?       38           
  Lines                  ?     5520           
  Branches               ?        0           
==============================================
  Hits                   ?     4158           
  Misses                 ?     1362           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EarlMilktea
Copy link
Contributor

@shinich1 I will directly push some changes to this branch for easier review. Watch out!

Copy link
Contributor

@EarlMilktea EarlMilktea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MEMO: Doc CI is failing. Could you fix it?

graphix/pattern.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants