Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel execution for permutation_importance #244

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

luoq
Copy link

@luoq luoq commented Nov 3, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 3, 2017

Codecov Report

Merging #244 into master will decrease coverage by 0.38%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
- Coverage   97.26%   96.88%   -0.39%     
==========================================
  Files          44       44              
  Lines        2851     2855       +4     
  Branches      541      542       +1     
==========================================
- Hits         2773     2766       -7     
- Misses         41       48       +7     
- Partials       37       41       +4
Impacted Files Coverage Δ
eli5/sklearn/permutation_importance.py 100% <100%> (ø) ⬆️
eli5/permutation_importance.py 90.62% <80%> (-9.38%) ⬇️
eli5/sklearn/utils.py 87.32% <0%> (-2.82%) ⬇️
eli5/lime/utils.py 85.13% <0%> (-1.36%) ⬇️
eli5/xgboost.py 98.17% <0%> (-1.22%) ⬇️
eli5/lime/lime.py 96% <0%> (-1%) ⬇️

@@ -15,6 +15,7 @@

import numpy as np # type: ignore
from sklearn.utils import check_random_state # type: ignore
from sklearn.externals.joblib import Parallel, delayed
Copy link
Contributor

@kmike kmike Nov 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can add # type: ignore to this line to make type checks pass

@kmike
Copy link
Contributor

kmike commented Nov 9, 2017

Thanks, looks like a great feature!

Tests are failing in Python 2.7; I'm not sure what it takes to make it work. Does it at least work with n_jobs=1?

@luoq
Copy link
Author

luoq commented Nov 10, 2017

@luoq
Copy link
Author

luoq commented Nov 10, 2017

@thomasfrederikhoeck
Copy link

Are you still working on this? Would be very useful.

@eyadsibai
Copy link

eyadsibai commented Mar 20, 2019

will you drop python2 soon, so this pr gets merged?

@eyadsibai
Copy link

shall we switch this to use https://joblib.readthedocs.io/en/latest/parallel.html instead?

@aridf
Copy link

aridf commented Jun 16, 2022

Can I ask what happened to this? Is there now a way to use eli5.sklearn.PermutationImportance() in parallel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants