Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mixin for MobType #1250

Open
wants to merge 2 commits into
base: 1.20
Choose a base branch
from
Open

Add mixin for MobType #1250

wants to merge 2 commits into from

Conversation

maxanier
Copy link
Member

@maxanier maxanier commented Aug 5, 2023

@Cheaterpaul What do you think about this approach?
Should not really impact performance, right?
Instead of instance of check, there is a delegate method and overwrite.

My idea is to introduce #770 as optional in 1.20/1.9 and let e.g. Mario test it.
In the future we could consider making it default.

@Cheaterpaul
Copy link
Member

I see no problem in the implementation. This should have no performance impact, only when called on the player and there we already have a VampirismAttributes class to minimize it.

But the main problem with making vampires undead is that all other game features will treat the vampire as undead. Yes this is the intention of this change, but before doing this we should make sure that no vanilla feature or vampirism feature have side effects with this change.

The smite enchantment for example deals 15.5 extra damage to undead entities which is simply to much against a player. I am not aware of any other side effects, but I suspect there are more.

@supermike1999
Copy link

Comparing it, you need Sharpness level 24 to match Smite 5 when attacking a undead mob. I simulated what it looks like in combat. (Normal player with [Smite 5 Netherite word] vs Maxed level Vampire with natural armor)

https://youtu.be/6kL4d2Wa6Jg (Video was way over 10mb limit)

@maxanier
Copy link
Member Author

Yeah, it will probably be a bit unfair, but people are asking for it, so why not make it an (off by default) option.
Maybe we can consider mitigating the balancing issues somehow later.

I will extend this configuration to vampire NPCs and merge eventually.

@maxanier maxanier changed the base branch from 1.20 to dev August 27, 2023 20:29
@maxanier maxanier changed the base branch from dev to 1.20 August 27, 2023 20:29
@maxanier maxanier marked this pull request as ready for review August 27, 2023 20:29
@Cheaterpaul
Copy link
Member

@Cheaterpaul add as experimental feature with enough warnings and take a look where this would be a problem.

Smite is a problem while harming / healing potions should be fine.

@Cheaterpaul Cheaterpaul self-assigned this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants