Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #119

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Fix CI #119

merged 2 commits into from
Dec 11, 2023

Conversation

4ver
Copy link
Member

@4ver 4ver commented Dec 11, 2023 •
edited
Loading

I can't seem to get the applescript method working on gha or locally so i disabled the tests for now.

TODO:

  • Update readme to mention dropped support for node <12
  • Bump packages

@Oxalin
Copy link
Collaborator

Oxalin commented Dec 11, 2023

About the TODO > Bump packages, do you mean to bump node-auto-launch or is it about the dependencies?

Oxalin
Oxalin approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@Oxalin Oxalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, I wrongly thought it was failing prior to your previous PR. This fix the CI checks.

@Oxalin Oxalin merged commit 30de879 into master Dec 11, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oxalin Oxalin Oxalin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4ver @Oxalin