-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eGo #53
base: main
Are you sure you want to change the base?
eGo #53
Conversation
added endpoint for updating users points with MOngoDB $inc operator
updated error messages and loading
…removed unused button styles, updated the user model with more validation rules and added some more validation to the register page to give the user more understandable feedback on the error
* added id as a part of the response when logging in * Wrote a simple slider who works with auth, but fetch and update * Updated the batteryslidercomponent to get id passed from energy card * Updated the nav path to dash to include id * Wrote the route to patch the energy * Added energy card as a nested route to the dashboard route
…vatar data in user model
…igate to user's dashboard and fixed so the user points will be updated at first fetch in dash
added accessibility
deleted unused files, structured svg in folders, redirected
removed consol-logs
switched png to svg, adjusted alignment graph
fixed position of BatteryUpdateIcon
added styling for adminpages
…e of our 30 char max lenght as we now hash passwords after changing the usermodel to pre hash passwords before storing them in db
Admin routes fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Eliane, Kathinka, Vittoria and Yifan, big congratulations on arriving to the end of the bootcamp and deliver your own app! 🎓
The app works well, has a good flow and is properly planned and organised, both on the frontend and the backend. The code is really well structured and written, clean formatted and readable, the backend is robust and structured in modules to improve scalability and readability. I'm impressed you had your own design, wireframe and made your own logos, such a professional way to work! Nice work with animations, the app is also accessible and fully-responsive! You should be PROUD! ⭐
Now, here's some fixes to apply to make it work flawlessly:
- after selecting a trip, the top right section with the chart is not updated unless performing a page refresh
- as soon as you click on eGo logo, it logs out- user should be persistently logged in unless it logs out
And here's some aspects that can be taken into consideration for further improvement:
- would be nice an onboarding / info on how to use the app or about points in the app (some simple descriptions would be enough)
I'll ask you to apply the fixes mentioned, thank you and again big congratulations 👏 You made it 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add this to .gitignore and delete the folder 🧹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to format your files 👍
fixed logo & graph on dashboard
##Netlify link
https://ego-app.netlify.app/
##Render link
https://project-final-1-4w43.onrender.com/
##Collaborators
[El1an3, Yifan-858,kathinka,vittoriamatteoli]