Project happy thoughts #449
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,52 @@ | ||
| /* eslint-disable no-underscore-dangle */ | ||
| /* eslint-disable no-unused-vars */ | ||
| import React, { useState, useEffect } from 'react'; | ||
| import { SubmitThoughts } from 'components/SubmitThoughts'; | ||
| import { ListThoughts } from 'components/ListThoughts'; | ||
|
|
||
| export const App = () => { | ||
| const [thoughtsList, setThoughtsList] = useState([]) | ||
| const [submitThoughts, setSubmitThoughts] = useState('') | ||
| const [loading, setLoading] = useState(false) | ||
|
|
||
| const fetchThoughts = () => { | ||
| setLoading(true) | ||
| fetch('https://happy-thoughts-ux7hkzgmwa-uc.a.run.app/thoughts') | ||
| .then((response) => response.json()) | ||
| .then((data) => setThoughtsList(data)) | ||
| .catch((error) => console.log(error)) | ||
| .finally(() => { setLoading(false) }) | ||
| } | ||
|
|
||
| useEffect(() => { | ||
| fetchThoughts() | ||
| }, []) | ||
|
|
||
|
Comment on lines
+21
to
+24
There was a problem hiding this comment. This hook is to call the fetchThoughts function when the component is mounted so this should/could/would also be moved if so we were to change the structure for a "cleaner" App.js |
||
| const handleFormSubmit = (event) => { | ||
| event.preventDefault() | ||
| setLoading(true) | ||
|
|
||
|
There was a problem hiding this comment. Since the "handleFormSubmit" handles the submission of a new thought it could be moved into your component "submitThoughts.js" instead if we want to continue on "cleaning" the app.js a bit. |
||
| const options = { | ||
| method: 'POST', | ||
| body: JSON.stringify({ message: submitThoughts }), | ||
| headers: { 'Content-Type': 'application/json' } | ||
| } | ||
| fetch('https://happy-thoughts-ux7hkzgmwa-uc.a.run.app/thoughts', options) | ||
| .then((response) => response.json()) | ||
| .then((data) => { setThoughtsList([data, ...thoughtsList]) }) | ||
| .catch((error) => console.log(error)) | ||
| .finally(() => { setLoading(false) }) | ||
| } | ||
|
|
||
| return ( | ||
| <div> | ||
| <SubmitThoughts | ||
| submitThoughts={submitThoughts} | ||
| setSubmitThoughts={setSubmitThoughts} | ||
| handleFormSubmit={handleFormSubmit} /> | ||
| <ListThoughts | ||
| loading={loading} | ||
| thoughtsList={thoughtsList} /> | ||
| </div> | ||
| ); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| /* eslint-disable no-underscore-dangle */ | ||
| import React from 'react' | ||
|
|
||
| export const ListThoughts = ({ loading, thoughtsList }) => { | ||
| if (loading) { | ||
| return <h2>Loading...</h2> | ||
| } | ||
| return thoughtsList.map((thought) => { | ||
| return ( | ||
| <p key={thought._id}>{thought.message}</p> | ||
| ) | ||
| }) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import React from 'react' | ||
|
|
||
| export const SubmitThoughts = ({ handleFormSubmit, submitThoughts, setSubmitThoughts }) => { | ||
| <form onSubmit={handleFormSubmit}> | ||
| <textarea type="text" value={submitThoughts} onChange={(event) => setSubmitThoughts(event.target.value)} /> | ||
| <p> | ||
| <button type="submit">Submit form</button> | ||
| </p> | ||
| </form> | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep the App component cleaner (not really necessary I think in this size of projects but a good practise for the future when we work in bigger projects) this could've been places in one of your components. Since this is fetching the thoughts from the API it would be neat to place it in your ListThoughts.js maybe!