Martin MongoDB Api #491
Martin MongoDB Api #491
Conversation
| [ | ||
| { | ||
| "id": 1, | ||
| "name": "Fågelfjädersstav", |
| // import goldenGlobesData from "./data/golden-globes.json"; | ||
| // import netflixData from "./data/netflix-titles.json"; | ||
| // import topMusicData from "./data/top-music.json"; | ||
| import avocadoSalesData from "./data/avocado-sales.json"; |
| @@ -24,9 +45,66 @@ const app = express(); | |||
| app.use(cors()); | |||
| app.use(express.json()); | |||
|
|
|||
| app.use((req, res, next) => { | |||
There was a problem hiding this comment.
Intressant, detta har jag missat! Fick köra en chatGPT för förklaring. Topp!!
/Izabel
| ); | ||
| } | ||
| // Query to filter out all entries at a price point lower than the query. | ||
| const priceSearch = req.query.price; |
There was a problem hiding this comment.
Gillar att du har flera query filtreringar! Dock så ser man inte det i lista med endpoints, så det vore toppen att veta vad man kan söka på 😄
/Izabel
| } | ||
| }); | ||
|
|
||
| app.get("/magic-items/:id", async (req, res) => { |
There was a problem hiding this comment.
Ser att du har två id endpoints, antar att denna är för _id som tilldelas? Men ser den inte i din data, så vet inte vad dessa id är och kan inte söka på dem..?
Konstigt nog ser jag bara din egna id nyckel. (Gud vad skumt att skriva kod på svenska)
/Izabel
There was a problem hiding this comment.
Hi Martin, good job deploying your first database! 🚀 The code meets the requirements and it's well structured. Here is what can be improved:
- Your Express routes are well-defined and handle various scenarios such as fetching all magic items, filtering by colour and price, and retrieving a specific item by ID. However, you have defined two routes with the same path (/magic-items/:id). Go ahead and remove one of them to avoid conflicts
- Would be nice to document every filtering criteria in your API, you could add the available search queries when listing the endpoint:
app.get("/", (req, res) => {
let endpoints = expressListEndpoints(app);
// Add information about search queries to each endpoint
endpoints = endpoints.map(endpoint => {
// Customize this object to include information about search queries for each endpoint
if (endpoint.path === "/magic-items") {
endpoint.searchQueries = {
color: "Filter by color",
price: "Filter by price",
// Add more search queries as needed
};
}
return endpoint;
});
res.json(endpoints);
});also you can remove the datasets if unused :) Well done!
Netlify link
https://project-mongo-api-vcl5.onrender.com