Aline's first project draft for review #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esteficodes
reviewed
Oct 14, 2021
| <!DOCTYPE html> | ||
| <html> | ||
|
|
||
| <head> |
There was a problem hiding this comment.
Hi! Nice to meet you! I'm Estefanía and I'll be taking a look at your site's code to see how can we make it functional and shiny.👋😀.
| <meta charset="utf-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Aline's page</title> | ||
| <link rel="stylesheet" type="text/css" href="style.css"> |
There was a problem hiding this comment.
Maybe you forgot to close the head tag?
Comment on lines
+10
to
+16
| <!-- | ||
| Write your code here inside the body to make it appear in the browser. | ||
| Below is an example on how to use an image tag. Copy it and add it in the body, but outside the comment tag if you want to see how it looks like on the website. Then you can change the size and other styling for it in the css file. | ||
|
|
||
| <img src="example-recipe-background.png" alt="Banana Bread"> | ||
|
|
||
| --> |
There was a problem hiding this comment.
Remember to erase all this comments once you are done.😀
Comment on lines
+17
to
+28
| <h1 class="top-heading">Aline Schlunegger</h1> | ||
| <h2 class="second-heading">Film-Online-Marketing-Redaktion 🎬✏️💬📱</h2> | ||
| <div class="light-coral-box"> | ||
| <p class="paragraphs">🎬 Film - und alle anderen Formate, die bewegen.<p> | ||
| <p class="paragraphs">Erfahrungen in: </p> | ||
| <p class="paragraphs">🎟 Filmmarketing</p> | ||
| <p class="paragraphs">🖋 Filmkritik</p> | ||
| <p class="paragraphs">📺 Vertrieb und Verleih</p> | ||
| <p class="paragraphs">🌎 International und national</p> | ||
| <p class="paragraphs">#️⃣🎞 Online und offline</p> | ||
| <p class="paragraphs">👩🏻🎓 funderiertes kultur- und filmwissenschaftliches Wissen.</p> | ||
| </div> |
There was a problem hiding this comment.
Something funny 🤡 is going on here with the indentation. Remember that if there's a new block, then you indent one more level. At Technigo, we use 2 spaces for indentation. Also: all the elements that are siblings should be in the same level. 🧑🤝🧑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Here's my very first very simple code for a webpage, looking forward to your feedback :D