Restaurant Fiescherblick #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I created a first draf for a restaurant website.
Update 30.10.2022
HIPPIEKICK
reviewed
Nov 7, 2022
| <div class="box"> | ||
| <div class="worker"> | ||
| <img src="images/Koch_quadratisch.png" alt="Banana Bread"> | ||
| <p>Vorname Nachname<br />Position</p> |
There was a problem hiding this comment.
<br/> is not used anymore. You could use flexbox for this ;)
Comment on lines
+131
to
+132
| <div class="footer_menubar"> | ||
| <div class="footer_menu_item"> |
There was a problem hiding this comment.
Minor thing but class name should be named in kebab-case, like this: footer-menu-item
Comment on lines
+172
to
+175
| .gallery1-1:hover{ | ||
| transform: scale(1.3); | ||
| z-index:2; | ||
| } |
There was a problem hiding this comment.
Very nice hover effect! Just remember indentation
Comment on lines
+234
to
+260
| .box img { | ||
| max-width: 200px; | ||
| border-radius: 100%; | ||
| -webkit-border-radius: 100%; | ||
| -moz-border-radius: 100%; | ||
| padding: 10px; | ||
| margin: 10px; | ||
| background: white; | ||
| border-color: #04391d; | ||
| border: 2px; | ||
| border-style: solid; | ||
| background-color: #04391d; | ||
| } | ||
|
|
||
| .box img:hover{ | ||
| max-width: 200px; | ||
| border-radius: 100%; | ||
| -webkit-border-radius: 100%; | ||
| -moz-border-radius: 100%; | ||
| padding: 10px; | ||
| margin: 10px; | ||
| background: white; | ||
| border-color: #04391d; | ||
| border: 2px; | ||
| border-style: solid; | ||
| background-color: #ffffff; | ||
| } |
There was a problem hiding this comment.
Nice hover effect here too!
Just remember that you only need to specify the things that are different from you original styling
|
|
||
| <body> | ||
| <div id="home" class="header"> | ||
| <a href="./index.html"class="logo"><img src="icons/Fiescherblick Logo grün.svg" alt="Logo Fiescherblick"></a> |
There was a problem hiding this comment.
Really nice that you put your images and icons in different folders. It makes it so much easier to overview your project ⭐
| <title>Restaurant Fiescherblick</title> | ||
| <!-- dont forget to add a css file and link it here! --> | ||
| <link rel="stylesheet" type="text/css" href="style.css"> | ||
| <!-- If you're using google fonts, that should be added here --> |
There was a problem hiding this comment.
Would be really nice with a google font 😍
|
|
||
| <div class="box2"> | ||
| <div class="map"> | ||
| <iframe src="https://www.google.com/maps/embed?pb=!1m14!1m8!1m3!1d10960.292996253223!2d8.0459933!3d46.625315!3m2!1i1024!2i768!4f13.1!3m3!1m2!1s0x0%3A0x4ed11045e4a7d95b!2sHotel%20Fiescherblick!5e0!3m2!1sde!2sch!4v1665255321505!5m2!1sde!2sch" width="700" height="450" style="border:0;" allowfullscreen="" loading="lazy" referrerpolicy="no-referrer-when-downgrade"></iframe> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attemp to create a landingpage for a restaurant. More or less responsive.