Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gaby and Gitte -Supoerpower Shenanigans project-survey-vite #81

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

Gaby and Gitte -Supoerpower Shenanigans project-survey-vite #81

wants to merge 53 commits into from

Conversation

gabster94
Copy link

gabster94 and others added 30 commits October 15, 2024 12:59
@gabster94
Created the sumbit button and connected it to the App.jsx file
5d1a75f
@gabster94
we tried to import the answers from the Q1 to Anwers. Not yet succeeded
0c56a5d
@gabster94
working with the aswers component
b45f11b
@gabster94
push before we start working in branches
618c9f6
@gittebe
- test git
098c189
@gittebe
Merge pull request #1 from gittebe/question-one
0d5bca9 
- test git
@gabster94
hippo
96ee59b
@gabster94
Merge pull request #2 from gabster94/gabys-branch
67e010a 
hippo
@gittebe
- test two
76be571
@gittebe
test
930f92b
@gittebe
Merge pull request #3 from gabster94/gitte
0f483fe 
Gitte
@gabster94
Did the Q3
a9b5752
@gabster94
Finished Q1
e02a30e
@gabster94
Created SubmitNew.jsx and put the submission function there. not work…
fb5385f 
…ing though. Think it has to do with the imports
@gabster94
Merge pull request #4 from gabster94/gabys-branch
13f9086 
Gabys branch
@gittebe
- chnaged app
fbc59cf
@gittebe
- changed app
8bfea8b
@gittebe
Merge remote-tracking branch 'origin' into gitte
14f904d
@gittebe
- added radio button question and fixed the SubminNew
2132a70
@gittebe
Merge pull request #5 from gabster94/gitte
393f093 
Gitte
@gittebe
- worked on App
58fd4ff
@gittebe
Merge branch 'main' of https://github.com/gabster94/project-survey-vite
24941e7
@gittebe
- worked on App
c0e0004
@gittebe
Merge branch 'gitte'
471f314
@gittebe
- App
758f709
@gabster94
added an import from SubmitNew.jsx in App.jsx
9fea9d7
@gabster94
Merge pull request #6 from gabster94/gabys-branch
a46e2ba 
added an import from SubmitNew.jsx in App.jsx
@gittebe
- app
1e4cd7f
@gittebe
Merge branch 'gitte'
865e48c
@gittebe
- changed components names, deleted components, added Props validation
03144be
gittebe and others added 21 commits October 17, 2024 13:28
@gittebe
- added props validation, added first map and css for component costume
d2ce0c9
@gittebe
- update
eae931d
@gittebe
Merge remote-tracking branch 'origin/main' into gitte
4793ca1
@gittebe
- added folder for name
f963a13
@gittebe
- added folder for strength
2afb694
@gittebe
- added CSS
50ac5db
@gittebe
- CSS
e32f00a
@gabster94
I stopped the nextStep function from continuing further, without a va…
447b17a 
…lue.moved case3 to submitForm instead, line 63
@gittebe
Merge pull request #7 from gabster94/gabys-branch
0d4f928 
I stopped the nextStep function from continuing further, without a va…
@gittebe
- added CSS
ad6e743
@gittebe
- added welcome page
a4a3328
@gabster94
aparently i have some changes that i dont know about...
1f44dcb
@gabster94
Merge branch 'main' of https://github.com/gabster94/project-survey-vite…
96b7814 
… into gabys-branch
@gabster94
Styling for buttons, changed the value for costume in costume.jsx
1799cbb
@gabster94
Merge pull request #9 from gabster94/gabys-branch
3ef0797 
Gabys branch
@gabster94
did some minor changes in our html tags across the project, moved the…
f58c916 
… inputs to the center
@gabster94
Merge pull request #10 from gabster94/gabys-branch
91ae9a4 
html & styling
@gittebe
- worked on css and added footer
a75553a
@gittebe
Merge pull request #11 from gabster94/gitte
87a907b 
- worked on css and added footer
@gabster94
changed the title
167c434
@gabster94
deploylink in readme
e90b8ff
@JennieDalgren JennieDalgren self-assigned this Oct 24, 2024
JennieDalgren
JennieDalgren requested changes Oct 24, 2024
View reviewed changes
Copy link

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with this project!

You have worked really well with the logic and new React use cases.
However, to be approved on this project you need to clean up your code, it looks like you maybe have different settings for your indentation. Which makes your code files looks not unified.
Also, your accessibility check with Lighthouse gives you 94, the requirements says at least 95. Take a look at your form labels...

Good job!

@gittebe
Copy link

gittebe commented Oct 28, 2024

Hi Jennie,
thank you for your code review. We will work on it!
I have a question regarding your analysis with Lighthouse. When we do it, it gives us a 100% accessibility back. Not sure why Lighthouse on your end shows a different percentage. Do you know it? Would be interesting for future projects :)

@gittebe
Copy link

gittebe commented Oct 29, 2024 •
edited
Loading

Hej! We made the requested changes! Thank you for your the feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JennieDalgren JennieDalgren JennieDalgren requested changes

Assignees

@JennieDalgren JennieDalgren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabster94 @gittebe @JennieDalgren