-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
W10 | project-survey-vite | Xing Y. & Erika O. #83
base: main
Are you sure you want to change the base?
Conversation
…hen the questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with this project!
Clean up some un useful console logs and fix the indentation in you css files.
Also take a look at the accessibility score on Lighthouse. The required number is at least 95. You got 89. I think it mainly has to do with color contrasts of you grey buttons.
Good job with components and great that you've added comments regarding each components purpose and functionality. It looks like you really focused on understanding the React state and components this week.
Do the small fixes and keep up the good work!
I implemented a validation function for both the 'Next' step and form submission, displaying validation messages in red text below the disabled button instead of using alerts. The button design was updated to a more modern shape, and I added value="" to the first option in the dropdown to ensure the button re-disables if an empty selection is made. |
Netlify link
https://survey-personality.netlify.app
Collaborators
Xing Y. & Erika O.